-
Notifications
You must be signed in to change notification settings - Fork 446
Use node16 #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node16 #2108
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ import { | |
SimpleSupportStatement, | ||
} from "bcd-idl-mapper"; | ||
import api from "bcd-idl-mapper"; | ||
import * as Browser from "../types"; | ||
import * as Browser from "../types.js"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
import { filterMapRecord, isEmptyRecord } from "../utils/record.js"; | ||
import { mapDefined } from "../helpers.js"; | ||
import { hasStableImplementation } from "./stable.js"; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { parse, type Value, type Node } from "kdljs"; | ||
import type { Enum, Event, Property, Interface, WebIdl } from "./types"; | ||
import type { Enum, Event, Property, Interface, WebIdl } from "./types.js"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Too late but this should really be d.ts There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, definitely not; this is correct. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that the PR moved the file to .ts; you can't import a .d.ts file straight up like that without also enabling flags that allow importing TS files. |
||
import { readdir, readFile } from "fs/promises"; | ||
import { merge } from "./helpers.js"; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same