Skip to content

Use node16 #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/createTypesPackages.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ const go = async () => {
async function updatePackageJSON(pkg, packagePath) {
const pkgJSONPath = new URL("package.json", packagePath);
const packageText = fs.readFileSync(pkgJSONPath, "utf8");
/** @type {import("./template/package.json")} */
/** @type {typeof import("./template/package.json")} */
const packageJSON = JSON.parse(packageText);
packageJSON.name = pkg.name;
packageJSON.description = pkg.description;
Expand Down
2 changes: 1 addition & 1 deletion src/build/bcd.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as Browser from "./types";
import * as Browser from "./types.js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

import {
CompatStatement,
SimpleSupportStatement,
Expand Down
2 changes: 1 addition & 1 deletion src/build/bcd/mapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
SimpleSupportStatement,
} from "bcd-idl-mapper";
import api from "bcd-idl-mapper";
import * as Browser from "../types";
import * as Browser from "../types.js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

import { filterMapRecord, isEmptyRecord } from "../utils/record.js";
import { mapDefined } from "../helpers.js";
import { hasStableImplementation } from "./stable.js";
Expand Down
2 changes: 1 addition & 1 deletion src/build/patches.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { parse, type Value, type Node } from "kdljs";
import type { Enum, Event, Property, Interface, WebIdl } from "./types";
import type { Enum, Event, Property, Interface, WebIdl } from "./types.js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late but this should really be d.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, definitely not; this is correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the PR moved the file to .ts; you can't import a .d.ts file straight up like that without also enabling flags that allow importing TS files.

import { readdir, readFile } from "fs/promises";
import { merge } from "./helpers.js";

Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"compilerOptions": {
"target": "es2022",
"module": "esnext",
"moduleResolution": "node",
"module": "node16",
"moduleResolution": "node16",
"outDir": "./lib",
"strict": true,
"esModuleInterop": true,
Expand Down