Closed
Conversation
ydz-one
force-pushed
the
Fix_RTCStatsType_values
branch
2 times, most recently
from
f8e46e6 to
d48c57b
Compare
ydz-one
force-pushed
the
Fix_RTCStatsType_values
branch
from
d48c57b to
c85cdfa
Compare
Contributor
|
https://github.com/microsoft/TSJS-lib-generator/blob/master/inputfiles/README.md says you should not edit this json... |
Author
|
Continuous doesn't pass if that json isn't edited tho |
sandersn
requested changes
Jun 5, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I agree with @HolgerJeromin, you should use the override json files instead of editing browser.webidl.preprocessed.json.
Collaborator
|
#1034 fixed this @github-actions close |
Contributor
|
Closing because @saschanaz is a code-owner of all the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change RTCStatsType values to match MDN docs
Fixes microsoft/TypeScript#36650