Skip to content

Remove unimplemented Web Authentication APIs #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 0 additions & 89 deletions baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@
/// DOM APIs
/////////////////////////////

interface Account {
displayName: string;
id: string;
imageURL?: string;
name?: string;
rpDisplayName: string;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -64,13 +56,6 @@ interface AnimationPlaybackEventInit extends EventInit {
timelineTime?: number | null;
}

interface AssertionOptions {
allowList?: ScopedCredentialDescriptor[];
extensions?: WebAuthnExtensions;
rpId?: string;
timeoutSeconds?: number;
}

interface AssignedNodesOptions {
flatten?: boolean;
}
Expand Down Expand Up @@ -189,15 +174,6 @@ interface ChannelSplitterOptions extends AudioNodeOptions {
numberOfOutputs?: number;
}

interface ClientData {
challenge: string;
extensions?: WebAuthnExtensions;
hashAlg: string | Algorithm;
origin: string;
rpId: string;
tokenBinding?: string;
}

interface ClientQueryOptions {
includeUncontrolled?: boolean;
type?: ClientTypes;
Expand Down Expand Up @@ -1636,24 +1612,6 @@ interface SVGBoundingBoxOptions {
stroke?: boolean;
}

interface ScopedCredentialDescriptor {
id: Int8Array | Int16Array | Int32Array | Uint8Array | Uint16Array | Uint32Array | Uint8ClampedArray | Float32Array | Float64Array | DataView | ArrayBuffer | null;
transports?: Transport[];
type: ScopedCredentialType;
}

interface ScopedCredentialOptions {
excludeList?: ScopedCredentialDescriptor[];
extensions?: WebAuthnExtensions;
rpId?: string;
timeoutSeconds?: number;
}

interface ScopedCredentialParameters {
algorithm: string | Algorithm;
type: ScopedCredentialType;
}

interface ScrollIntoViewOptions extends ScrollOptions {
block?: ScrollLogicalPosition;
inline?: ScrollLogicalPosition;
Expand Down Expand Up @@ -1867,9 +1825,6 @@ interface WaveShaperOptions extends AudioNodeOptions {
oversample?: OverSampleType;
}

interface WebAuthnExtensions {
}

interface WebGLContextAttributes {
alpha?: boolean;
antialias?: boolean;
Expand Down Expand Up @@ -14759,26 +14714,6 @@ declare var SVGZoomEvent: {
new(): SVGZoomEvent;
};

interface ScopedCredential {
readonly id: ArrayBuffer;
readonly type: ScopedCredentialType;
}

declare var ScopedCredential: {
prototype: ScopedCredential;
new(): ScopedCredential;
};

interface ScopedCredentialInfo {
readonly credential: ScopedCredential;
readonly publicKey: CryptoKey;
}

declare var ScopedCredentialInfo: {
prototype: ScopedCredentialInfo;
new(): ScopedCredentialInfo;
};

/** A screen, usually the one on which the current window is being rendered, and is obtained using window.screen. */
interface Screen {
readonly availHeight: number;
Expand Down Expand Up @@ -16365,28 +16300,6 @@ declare var WaveShaperNode: {
new(context: BaseAudioContext, options?: WaveShaperOptions): WaveShaperNode;
};

interface WebAuthentication {
getAssertion(assertionChallenge: Int8Array | Int16Array | Int32Array | Uint8Array | Uint16Array | Uint32Array | Uint8ClampedArray | Float32Array | Float64Array | DataView | ArrayBuffer | null, options?: AssertionOptions): Promise<WebAuthnAssertion>;
makeCredential(accountInformation: Account, cryptoParameters: ScopedCredentialParameters[], attestationChallenge: Int8Array | Int16Array | Int32Array | Uint8Array | Uint16Array | Uint32Array | Uint8ClampedArray | Float32Array | Float64Array | DataView | ArrayBuffer | null, options?: ScopedCredentialOptions): Promise<ScopedCredentialInfo>;
}

declare var WebAuthentication: {
prototype: WebAuthentication;
new(): WebAuthentication;
};

interface WebAuthnAssertion {
readonly authenticatorData: ArrayBuffer;
readonly clientData: ArrayBuffer;
readonly credential: ScopedCredential;
readonly signature: ArrayBuffer;
}

declare var WebAuthnAssertion: {
prototype: WebAuthnAssertion;
new(): WebAuthnAssertion;
};

interface WebGL2RenderingContext extends WebGL2RenderingContextBase, WebGL2RenderingContextOverloads, WebGLRenderingContextBase {
}

Expand Down Expand Up @@ -20115,7 +20028,6 @@ type RequestRedirect = "error" | "follow" | "manual";
type ResidentKeyRequirement = "discouraged" | "preferred" | "required";
type ResizeQuality = "high" | "low" | "medium" | "pixelated";
type ResponseType = "basic" | "cors" | "default" | "error" | "opaque" | "opaqueredirect";
type ScopedCredentialType = "ScopedCred";
type ScrollBehavior = "auto" | "smooth";
type ScrollLogicalPosition = "center" | "end" | "nearest" | "start";
type ScrollRestoration = "auto" | "manual";
Expand All @@ -20129,7 +20041,6 @@ type SpeechSynthesisErrorCode = "audio-busy" | "audio-hardware" | "canceled" | "
type TextTrackKind = "captions" | "chapters" | "descriptions" | "metadata" | "subtitles";
type TextTrackMode = "disabled" | "hidden" | "showing";
type TouchType = "direct" | "stylus";
type Transport = "ble" | "nfc" | "usb";
type UserVerificationRequirement = "discouraged" | "preferred" | "required";
type VRDisplayEventReason = "mounted" | "navigation" | "requested" | "unmounted";
type VideoFacingModeEnum = "environment" | "left" | "right" | "user";
Expand Down
4 changes: 0 additions & 4 deletions baselines/dom.iterable.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,10 +267,6 @@ interface WEBGL_draw_buffers {
drawBuffersWEBGL(buffers: Iterable<GLenum>): void;
}

interface WebAuthentication {
makeCredential(accountInformation: Account, cryptoParameters: Iterable<ScopedCredentialParameters>, attestationChallenge: Int8Array | Int16Array | Int32Array | Uint8Array | Uint16Array | Uint32Array | Uint8ClampedArray | Float32Array | Float64Array | DataView | ArrayBuffer | null, options?: ScopedCredentialOptions): Promise<ScopedCredentialInfo>;
}

interface WebGL2RenderingContextBase {
clearBufferfv(buffer: GLenum, drawbuffer: GLint, values: Iterable<GLfloat>, srcOffset?: GLuint): void;
clearBufferiv(buffer: GLenum, drawbuffer: GLint, values: Iterable<GLint>, srcOffset?: GLuint): void;
Expand Down
1 change: 0 additions & 1 deletion inputfiles/knownTypes.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"BigInteger",
"ByteLengthChunk",
"CanvasRenderingContext2DSettings",
"ClientData",
"ClientQueryOptions",
"ClientTypes",
"CompositeOperationOrAuto",
Expand Down
4 changes: 4 additions & 0 deletions inputfiles/removedTypes.json
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@
}
}
},
"ScopedCredential": null,
"ScopedCredentialInfo": null,
"ShadowRoot": {
"properties": {
"property": {
Expand Down Expand Up @@ -345,6 +347,8 @@
}
},
"VideoTrackList": null,
"WebAuthentication": null,
"WebAuthnAssertion": null,
"WebKitCSSMatrix": null,
"WebKitDirectoryEntry": null,
"WebKitDirectoryReader": null,
Expand Down