Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use declare class for namespaced types #961

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Dec 11, 2020

Unlike #858, which failed because classes declared in the global scope exist only on the global Declarative Environment Record, classes exported from TypeScript’s namespace construct exist as own properties of the namespace object, which matches the WebIDL behaviour.

To consider:

Depends on:

@ExE-Boss ExE-Boss requested a review from sandersn as a code owner December 11, 2020 19:33
@sandersn
Copy link
Member

This doesn't address #858 (comment), does it? That should be the first step in this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants