Skip to content

Add useUnknownInCatchVariables -> recommended #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

Add useUnknownInCatchVariables -> recommended #2251

merged 1 commit into from
May 18, 2023

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Feb 1, 2022

Pull the recommended options from ts.defaultInitCompilerOptions and ts.optionDeclarations[].strictFlag, to pick up future updates, like defaultsForOptions and allowedValues do.

Currently, the only difference is that useUnknownInCatchVariables is missing (this change adds it -> recommended).

--init doesn't include exactOptionalPropertyTypes yet.

@jablko
Copy link
Contributor Author

jablko commented Feb 1, 2022

I think the CI failure is fixed by microsoft/TypeScript-Website-Localizations#135?

orta
orta approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think defaulting to anything we recommend in --init and --strict is a good call 👍🏻

@jakebailey jakebailey closed this May 18, 2023
@jakebailey jakebailey reopened this May 18, 2023
@jakebailey jakebailey enabled auto-merge (squash) May 18, 2023 05:07
@jakebailey jakebailey merged commit b1c6c44 into microsoft:v2 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jablko @orta @jakebailey