Move ArrayBufferView from es5.d.ts to dom.generated.d.ts #15022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary change to provide ArrayBufferView type and solve PR deadlock before TSJS-lib-generator PR merge.
8 tasks
|
@mhegazy Can you review this? Normally I would just wait for a review but it seems PRs with no ping eventually get forgotten. Should we do this or you prefer just ignoring ArrayBufferView on TSJS-lib-generator side? |
saschanaz
force-pushed
the
arraybufferview
branch
from
2c7c240 to
25b0fbc
Compare
|
I'll drop this, WebIDL also has Function definition and removing this on lib.d.ts makes no sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR modifies dom.generated.d.ts which normally is not permitted.
It is done to solve PR deadlock with TSJS-lib-generator, where removing the type on es5.d.ts errors on TS repo and adding the type on TSJS-lib-generator also errors because of duplication
This PR is related to microsoft/TypeScript-DOM-lib-generator#227 which provides ArrayBufferView type by parsing Web IDL standard specification.
Expected behavior:
ArrayBufferView is not ECMAScript-defined type but a Web IDL-defined one and thus should be provided by TSJS-lib-generator. It also is defined as a union type rather than an interface.
Actual behavior:
ArrayBufferView is in es5.d.ts and is an interface type.