Revert the DOM query changes #42230
Merged
Revert the DOM query changes #42230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot run dt |
|
OK, so the biggest issue seems to be that conflicts with Nodes version which isn't nullable, I'll look into making the DOM version non-null. |
|
@typescript-bot run dt |
|
OK, this is a big improvement - I'm going to merge this, so that it doesn't block others using the |
8 tasks
sandersn
added a commit
that referenced
this pull request
Jan 8, 2021
sandersn
added a commit
that referenced
this pull request
Jan 8, 2021
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
* Revert the DOM query changes * Adds baselines * Hotfix for the removeal of the url nullabulity for testing
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts to handle the feedback in #42067