🤖 User test baselines have changed for refs/heads/master #42842

typescript-bot · 2021-02-17T18:59:59Z

This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @microsoft/typescript

typescript-bot · 2021-02-17T19:00:08Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

sandersn

Finished looking at the docker tests.

sandersn · 2021-03-31T20:24:09Z

tests/baselines/reference/docker/azure-sdk.log

+--[ FAILURE: @azure/dev-tool ]-------------------------------[ ? seconds ]--
+Invoking: tsc 
+src/commands/about.ts(39,44): error TS1109: Expression expected.
+src/commands/about.ts(39,51): error TS1005: ':' expected.


looks like errors from a version that doesn't support ??:

const dirs = (options.directory ?? [process.cwd()]).map((p) => path.resolve(p));

Which means our tsc insertion is probably broken.

@weswigham can you look at this?

sandersn · 2021-04-01T16:04:09Z

tests/baselines/reference/docker/vscode.log

@@ -3,22 +3,22 @@ Standard output:
 yarn run vX.X.X
 $ node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js compile
 [XX:XX:XX] Using gulpfile /vscode/gulpfile.js
-[XX:XX:XX] [monaco.d.ts] monaco.d.ts is changed - total time took ?s
+[XX:XX:XX] Error: /vscode/extensions/html-language-features/server/src/modes/javascriptMode.ts(130,36): Expected 7 arguments, but got 6.


Broken in #42890; the associated fixup PR microsoft/vscode#117092 doesn't cover this line of code.

@andrewbranch can you look at this?

microsoft/vscode#120362

sandersn · 2021-04-01T16:17:34Z

tests/baselines/reference/docker/vue-next.log

+Warning: dist/packages/compiler-core/src/options.d.ts:151:43 - (tsdoc-escape-right-brace) The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag
+Warning: dist/packages/compiler-core/src/options.d.ts:151:35 - (tsdoc-malformed-inline-tag) Expecting a TSDoc tag starting with "{@"
+Warning: dist/packages/compiler-core/src/options.d.ts:151:36 - (tsdoc-malformed-inline-tag) Expecting a TSDoc tag starting with "{@"
+Warning: /vue-next/packages/reactivity/src/baseHandlers.ts:198:3 - (TS2322) Type '(string | number | symbol)[]' is not assignable to type '(string | symbol)[]'.


this was fixed in Jan 4. I think the tsc version is wrong here too -- it must be 4.1 or older.

sandersn · 2021-04-01T16:26:01Z

tests/baselines/reference/user/adonis-framework.log

@@ -136,7 +136,6 @@ node_modules/adonis-framework/src/Response/index.js(56,7): error TS1056: Accesso
 node_modules/adonis-framework/src/Response/index.js(68,7): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher.
 node_modules/adonis-framework/src/Response/index.js(76,15): error TS2304: Cannot find name 'Mixed'.
 node_modules/adonis-framework/src/Response/index.js(95,16): error TS2304: Cannot find name 'Html'.
-node_modules/adonis-framework/src/Response/index.js(144,12): error TS1003: Identifier expected.


@link parsing

sandersn · 2021-04-01T16:28:54Z

tests/baselines/reference/user/bluebird.log

@@ -178,9 +178,6 @@ node_modules/bluebird/js/release/using.js(78,20): error TS2339: Property 'doDisp
 node_modules/bluebird/js/release/using.js(92,14): error TS2339: Property 'constructor$' does not exist on type 'FunctionDisposer'.
 node_modules/bluebird/js/release/using.js(97,23): error TS2339: Property 'data' does not exist on type 'FunctionDisposer'.
 node_modules/bluebird/js/release/using.js(223,15): error TS2350: Only a void function can be called with the 'new' keyword.
-node_modules/bluebird/js/release/util.js(279,45): error TS2345: Argument of type 'PropertyDescriptor | { value: any; } | undefined' is not assignable to parameter of type 'PropertyDescriptor & ThisType<any>'.


it's either different behaviour with union signatures or module.exports w/control flow

sandersn · 2021-04-01T17:15:09Z

tests/baselines/reference/user/chrome-devtools-frontend.log

@@ -3578,11 +3593,6 @@ node_modules/chrome-devtools-frontend/front_end/bindings/BlackboxManager.js(341,
 node_modules/chrome-devtools-frontend/front_end/bindings/BlackboxManager.js(351,31): error TS2694: Namespace 'Protocol' has no exported member 'Debugger'.
 node_modules/chrome-devtools-frontend/front_end/bindings/BlackboxManager.js(362,31): error TS2694: Namespace 'Protocol' has no exported member 'Debugger'.
 node_modules/chrome-devtools-frontend/front_end/bindings/BlackboxManager.js(375,9): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'.
-node_modules/chrome-devtools-frontend/front_end/bindings/BreakpointManager.js(54,5): error TS2322: Type 'Multimap<string | K, V | Breakpoint>.Multimap<string | K, V | Breakpoint>' is not assignable to type 'Multimap<string, Breakpoint>'.


improvement, although I'm not sure it's an improvement in constructor-control-flow for properties, contextual typing for inference or a fix to instantiation in JS.

sandersn · 2021-04-01T17:16:46Z

tests/baselines/reference/user/chrome-devtools-frontend.log

@@ -4919,8 +5038,6 @@ node_modules/chrome-devtools-frontend/front_end/data_grid/DataGrid.js(1764,7): e
  'this' could be instantiated with an arbitrary type which could be unrelated to 'NODE_TYPE'.
 node_modules/chrome-devtools-frontend/front_end/data_grid/DataGrid.js(1764,43): error TS2345: Argument of type 'this' is not assignable to parameter of type 'NODE_TYPE'.
  'NODE_TYPE' could be instantiated with an arbitrary type which could be unrelated to 'this'.
-    Type 'DataGridNode<NODE_TYPE>' is not assignable to type 'NODE_TYPE'.


improvement in elaboration probably

sandersn · 2021-04-01T17:22:18Z

tests/baselines/reference/user/chrome-devtools-frontend.log

      The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
-        Type 'IteratorResult<Promise<ComputedStyle> | Promise<CSSMatchedStyles>, any>' is not assignable to type 'IteratorResult<ComputedStyle | PromiseLike<ComputedStyle>, any>'.


type sorting

sandersn · 2021-04-01T18:18:25Z

tests/baselines/reference/user/fp-ts.log

+
+
+Standard error:
+FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory


doesn't repro locally or with a standalone compile

sandersn · 2021-04-01T18:26:41Z

tests/baselines/reference/user/npm.log

-lib/birthday.js(5,20): error TS2538: Type 'Buffer' cannot be used as an index type.
-lib/bugs.js(44,17): error TS2554: Expected 0 arguments, but got 2.
-lib/cache.js(108,32): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
+lib/access.js(27,14): error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'Access'.


this is new code in npm. tsc doesn't like it

sandersn · 2021-04-01T18:28:10Z

tests/baselines/reference/user/npm.log

+lib/access.js(27,14): error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'Access'.
+lib/adduser.js(16,14): error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'AddUser'.
+lib/audit.js(14,14): error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'Audit'.
+lib/base-command.js(15,29): error TS2339: Property 'description' does not exist on type 'Function'.


same. this is kind of a pattern with npm...

sandersn

I'm going to merge these changes because I'm tired of looking at them and they're hurting my ability to diff incoming PRs.

typescript-bot mentioned this pull request Feb 17, 2021

CI Status Thread #33716

Closed

typescript-bot force-pushed the user-baseline-updates branch from 3a26819 to 8b92238 Compare February 17, 2021 19:00

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 17, 2021

typescript-bot force-pushed the user-baseline-updates branch 26 times, most recently from b5b884d to f2dc61d Compare February 23, 2021 15:15

typescript-bot force-pushed the user-baseline-updates branch 7 times, most recently from 86bcd22 to e1323e8 Compare April 1, 2021 04:53

sandersn reviewed Apr 1, 2021

View reviewed changes

typescript-bot force-pushed the user-baseline-updates branch 17 times, most recently from fd2ed65 to 66f5286 Compare April 6, 2021 04:51

Update user baselines +cc @sandersn

4db6968

typescript-bot force-pushed the user-baseline-updates branch from 66f5286 to 4db6968 Compare April 6, 2021 15:10

sandersn approved these changes Apr 6, 2021

View reviewed changes

sandersn merged commit a56baa7 into microsoft:master Apr 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🤖 User test baselines have changed for refs/heads/master #42842

🤖 User test baselines have changed for refs/heads/master #42842

typescript-bot commented Feb 17, 2021

typescript-bot commented Feb 17, 2021

sandersn left a comment

sandersn Mar 31, 2021

sandersn Apr 1, 2021

andrewbranch Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn Apr 1, 2021

sandersn left a comment

		The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
		Type 'IteratorResult<Promise<ComputedStyle> \| Promise<CSSMatchedStyles>, any>' is not assignable to type 'IteratorResult<ComputedStyle \| PromiseLike<ComputedStyle>, any>'.



		Standard error:
		FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

🤖 User test baselines have changed for refs/heads/master #42842

🤖 User test baselines have changed for refs/heads/master #42842

Conversation

typescript-bot commented Feb 17, 2021

typescript-bot commented Feb 17, 2021

sandersn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sandersn left a comment

Choose a reason for hiding this comment