Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly use ownMap from module resolution cache #43986

Merged
merged 2 commits into from
May 7, 2021

Conversation

sheetalkamat
Copy link
Member

This was reported in #42173 (comment) and cause is that we were using incorrect value of ownMap from the actual ownMap in cache of redirects

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@amcasey
Copy link
Member

amcasey commented May 7, 2021

I stared at this for 5 minutes because GH folded away the setter. 🤦

@sheetalkamat sheetalkamat merged commit cfed79b into master May 7, 2021
@sheetalkamat sheetalkamat deleted the moduleCacheResetIssue branch May 7, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants