Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate over 4.4 lib dom and webworker #45324

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Migrate over 4.4 lib dom and webworker #45324

merged 4 commits into from
Aug 5, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Aug 4, 2021

Finalizes changes from the beta to RC.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 4, 2021
@@ -152,6 +152,12 @@ interface BlobPropertyBag {
type?: string;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes from the RC are adding deprecated or switching the deprecated to multiline. Though this includes a lot of the beta feedback about the DOM changes in #45047

@@ -5,14 +5,15 @@
interface AddEventListenerOptions extends EventListenerOptions {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big changes, but this brings this file up-to-date with the dom.d.ts changes. WebWorker being opt-in meant we focused on the dom changes for the beta and these follow on.

@orta
Copy link
Contributor Author

orta commented Aug 4, 2021

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 4, 2021

Heya @orta, I've started to run the parallelized community code test suite on this PR at 2bba7ee. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 4, 2021

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 2bba7ee. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 4, 2021

Heya @orta, I've started to run the extended test suite on this PR at 2bba7ee. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@orta
Copy link
Contributor Author

orta commented Aug 4, 2021

The node12 is from a timeout, which Seems unrelated. Will re-trigger. A lot of the RWC errors seems to have come from the addition of abort to AbortSignal which DefinitelyTyped/DefinitelyTyped#54944 should fix, the same for DT tests.

There's a good question of if we want to ship that change, given that it would force quite a few projects to update their node types version which isn't great.

@sandersn
Copy link
Member

sandersn commented Aug 4, 2021

For now I've cherry-picked those 3 PRs into this PR. We can change the types further in the final release of 4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants