-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate over 4.4 lib dom and webworker #45324
Conversation
@@ -152,6 +152,12 @@ interface BlobPropertyBag { | |||
type?: string; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes from the RC are adding deprecated
or switching the deprecated to multiline. Though this includes a lot of the beta feedback about the DOM changes in #45047
@@ -5,14 +5,15 @@ | |||
interface AddEventListenerOptions extends EventListenerOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big changes, but this brings this file up-to-date with the dom.d.ts
changes. WebWorker being opt-in meant we focused on the dom changes for the beta and these follow on.
@typescript-bot test this |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
The node12 is from a timeout, which Seems unrelated. Will re-trigger. A lot of the RWC errors seems to have come from the addition of There's a good question of if we want to ship that change, given that it would force quite a few projects to update their node types version which isn't great. |
We're giving Saschanaz a bit of time to see:
and a revised: |
For now I've cherry-picked those 3 PRs into this PR. We can change the types further in the final release of 4.4. |
Finalizes changes from the beta to RC.