Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve string delimiter in type printing. #60729

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Preserve string delimiter in type printing. #60729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2906dea
Preserve string delimiter in type printing.
dragomirtitian Dec 10, 2024
275f6b9
Only preserve string delimiters if we print for declaration files.
dragomirtitian Dec 16, 2024
638ceea
Preserve original quotes in all except errors.
dragomirtitian Dec 18, 2024
b8d575a
Preserve symbol name string delimiters
dragomirtitian Dec 18, 2024
1f2c52c
Improve preservation of strings in symbol printing.
dragomirtitian Dec 19, 2024
b983d7b
Improve symbol printing.
dragomirtitian Jan 9, 2025
78f7c22
Improve respect of string delimiter preferences.
dragomirtitian Jan 13, 2025
569b7ce
Revereted to using [] for missing names.
dragomirtitian Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
217 changes: 165 additions & 52 deletions src/compiler/checker.ts
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion src/compiler/emitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,7 +2099,10 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
// SyntaxKind.TemplateTail
function emitLiteral(node: LiteralLikeNode, jsxAttributeEscape: boolean) {
const text = getLiteralTextOfNode(node, /*sourceFile*/ undefined, printerOptions.neverAsciiEscape, jsxAttributeEscape);
if (
if ((node.kind === SyntaxKind.StringLiteral || node.kind === SyntaxKind.NumericLiteral) && (node as StringLiteral).symbol) {
writeSymbol(text, (node as StringLiteral).symbol);
}
else if (
(printerOptions.sourceMap || printerOptions.inlineSourceMap)
&& (node.kind === SyntaxKind.StringLiteral || isTemplateLiteralKind(node.kind))
) {
Expand Down
17 changes: 9 additions & 8 deletions src/compiler/expressionToTypeNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ import {
NodeBuilderFlags,
NodeFlags,
nodeIsMissing,
NoSubstitutionTemplateLiteral,
ObjectLiteralExpression,
ParameterDeclaration,
ParenthesizedExpression,
Expand Down Expand Up @@ -193,7 +192,7 @@ export function createSyntacticTypeNodeBuilder(
function reuseNode<T extends Node>(context: SyntacticTypeNodeBuilderContext, node: T, range?: Node): T;
function reuseNode<T extends Node>(context: SyntacticTypeNodeBuilderContext, node: T | undefined, range?: Node): T | undefined;
function reuseNode<T extends Node>(context: SyntacticTypeNodeBuilderContext, node: T | undefined, range: Node | undefined = node) {
return node === undefined ? undefined : resolver.markNodeReuse(context, node.flags & NodeFlags.Synthesized ? node : factory.cloneNode(node), range ?? node);
return node === undefined ? undefined : resolver.markNodeReuse(context, node, range ?? node);
}
function tryReuseExistingTypeNode(context: SyntacticTypeNodeBuilderContext, existing: TypeNode): TypeNode | undefined {
const { finalizeBoundary, startRecoveryScope, hadError, markError } = resolver.createRecoveryBoundary(context);
Expand Down Expand Up @@ -532,10 +531,13 @@ export function createSyntacticTypeNodeBuilder(
setEmitFlags(clone, flags | (context.flags & NodeBuilderFlags.MultilineObjectLiterals && isTypeLiteralNode(node) ? 0 : EmitFlags.SingleLine));
return clone;
}
if (isStringLiteral(node) && !!(context.flags & NodeBuilderFlags.UseSingleQuotesForStringLiteralType) && !node.singleQuote) {
const clone = factory.cloneNode(node);
(clone as Mutable<typeof clone>).singleQuote = true;
return clone;
if (isStringLiteral(node)) {
return setOriginalNode(
context.flags & (NodeBuilderFlags.UseSingleQuotesForStringLiteralType | NodeBuilderFlags.UseDoubleQuotesForStringLiteralType) ?
factory.createStringLiteral(node.text, !!(context.flags & NodeBuilderFlags.UseSingleQuotesForStringLiteralType)) :
factory.createStringLiteralFromNode(node),
node,
);
}
if (isConditionalTypeNode(node)) {
const checkType = visitNode(node.checkType, visitExistingNodeTreeSymbols, isTypeNode)!;
Expand Down Expand Up @@ -942,13 +944,12 @@ export function createSyntacticTypeNodeBuilder(
break;
default:
let typeKind: KeywordTypeSyntaxKind | undefined;
let primitiveNode = node as PrimitiveLiteral;
const primitiveNode = node as PrimitiveLiteral;
switch (node.kind) {
case SyntaxKind.NumericLiteral:
typeKind = SyntaxKind.NumberKeyword;
break;
case SyntaxKind.NoSubstitutionTemplateLiteral:
primitiveNode = factory.createStringLiteral((node as NoSubstitutionTemplateLiteral).text);
typeKind = SyntaxKind.StringKeyword;
break;
case SyntaxKind.StringLiteral:
Expand Down
9 changes: 7 additions & 2 deletions src/compiler/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5489,7 +5489,8 @@ export const enum NodeBuilderFlags {
UseTypeOfFunction = 1 << 12, // Build using typeof instead of function type literal
OmitParameterModifiers = 1 << 13, // Omit modifiers on parameters
UseAliasDefinedOutsideCurrentScope = 1 << 14, // Allow non-visible aliases
UseSingleQuotesForStringLiteralType = 1 << 28, // Use single quotes for string literal type
UseSingleQuotesForStringLiteralType = 1 << 28, // Force single quotes for string literal type or preserve source delimiters
UseDoubleQuotesForStringLiteralType = 1 << 30, // Force double quotes for string literal type or preserve source delimiters
NoTypeReduction = 1 << 29, // Don't call getReducedType
OmitThisParameter = 1 << 25,

Expand Down Expand Up @@ -5544,6 +5545,7 @@ export const enum TypeFormatFlags {

UseAliasDefinedOutsideCurrentScope = 1 << 14, // For a `type T = ... ` defined in a different file, write `T` instead of its value, even though `T` can't be accessed in the current scope.
UseSingleQuotesForStringLiteralType = 1 << 28, // Use single quotes for string literal type
UseDoubleQuotesForStringLiteralType = 1 << 30, // Use double quotes for string literal type
NoTypeReduction = 1 << 29, // Don't call getReducedType
OmitThisParameter = 1 << 25,

Expand All @@ -5563,7 +5565,7 @@ export const enum TypeFormatFlags {
NodeBuilderFlagsMask = NoTruncation | WriteArrayAsGenericType | GenerateNamesForShadowedTypeParams | UseStructuralFallback | WriteTypeArgumentsOfSignature |
UseFullyQualifiedType | SuppressAnyReturnType | MultilineObjectLiterals | WriteClassExpressionAsTypeLiteral |
UseTypeOfFunction | OmitParameterModifiers | UseAliasDefinedOutsideCurrentScope | AllowUniqueESSymbolType | InTypeAlias |
UseSingleQuotesForStringLiteralType | NoTypeReduction | OmitThisParameter,
UseSingleQuotesForStringLiteralType | UseDoubleQuotesForStringLiteralType | NoTypeReduction | OmitThisParameter,
}

// dprint-ignore
Expand Down Expand Up @@ -5592,6 +5594,9 @@ export const enum SymbolFormatFlags {

// Skip building an accessible symbol chain
/** @internal */ DoNotIncludeSymbolChain = 1 << 5,

UseSingleQuotesForStringLiteralType = 1 << 6, // Use single quotes for string literal type
UseDoubleQuotesForStringLiteralType = 1 << 7, // Use double quote for string literal type
}

/** @internal */
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/aliasDoesNotDuplicateSignatures.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ declare namespace demoNS {
>f : Symbol(f, Decl(demo.d.ts, 0, 26))
}
declare module 'demoModule' {
>'demoModule' : Symbol("demoModule", Decl(demo.d.ts, 2, 1))
>'demoModule' : Symbol('demoModule', Decl(demo.d.ts, 2, 1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see symbol baselines change; were we inconsistent with these before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbol printing is involved in type printing and error printing. I applied the 'preserve source code delimiters in everything except errors' to the symbol printing too. This does mean that the delimiters are now preserved in symbol baselines where they previously were not.

Were they always replaced before? Don't think so. Some error messages used symbol printing for the property names and we can see in error baselines changes that some of those kept the ' delimiter instead of having it replaced with "

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I tried doing this in typeWriter.ts:

let symbolString = "Symbol(" + this.checker.symbolToString(symbol, node.parent, undefined, ts.SymbolFormatFlags.AllowAnyNodeKind | ts.SymbolFormatFlags.UseDoubleQuotesForStringLiteralType);

And it actually still changed a whole bunch of double quotes to single quotes.... Is there some place which is not respecting the flag?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest changes, the above seems to actually work, though I don't think I actually think it matters; preserving stuff seems reasonable enough.


import alias = demoNS;
>alias : Symbol(alias, Decl(demo.d.ts, 3, 29))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/ambientDeclarations.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ var q = M1.fn();
// Ambient external module in the global module
// Ambient external module with a string literal name that is a top level external module name
declare module 'external1' {
>'external1' : Symbol("external1", Decl(ambientDeclarations.ts, 67, 16))
>'external1' : Symbol('external1', Decl(ambientDeclarations.ts, 67, 16))

var q;
>q : Symbol(q, Decl(ambientDeclarations.ts, 72, 7))
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/ambientDeclarationsExternal.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var n: number;
=== decls.ts ===
// Ambient external module with export assignment
declare module 'equ' {
>'equ' : Symbol("equ", Decl(decls.ts, 0, 0))
>'equ' : Symbol('equ', Decl(decls.ts, 0, 0))

var x;
>x : Symbol(x, Decl(decls.ts, 2, 7))
Expand All @@ -32,7 +32,7 @@ declare module 'equ' {
}

declare module 'equ2' {
>'equ2' : Symbol("equ2", Decl(decls.ts, 4, 1))
>'equ2' : Symbol('equ2', Decl(decls.ts, 4, 1))

var x: number;
>x : Symbol(x, Decl(decls.ts, 7, 7))
Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/ambientErrors.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,16 @@ module M2 {
>M2 : Symbol(M2, Decl(ambientErrors.ts, 42, 1))

declare module 'nope' { }
>'nope' : Symbol("nope", Decl(ambientErrors.ts, 45, 11))
>'nope' : Symbol('nope', Decl(ambientErrors.ts, 45, 11))
}

// Ambient external module with a string literal name that isn't a top level external module name
declare module '../foo' { }
>'../foo' : Symbol("../foo", Decl(ambientErrors.ts, 47, 1))
>'../foo' : Symbol('../foo', Decl(ambientErrors.ts, 47, 1))

// Ambient external module with export assignment and other exported members
declare module 'bar' {
>'bar' : Symbol("bar", Decl(ambientErrors.ts, 50, 27))
>'bar' : Symbol('bar', Decl(ambientErrors.ts, 50, 27))

var n;
>n : Symbol(n, Decl(ambientErrors.ts, 54, 7))
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/ambientErrors.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ declare var x = 4;

// Ambient functions with invalid overloads
declare function fn(x: number): string;
>fn : { (x: number): string; (x: "foo"): number; }
>fn : { (x: number): string; (x: 'foo'): number; }
> : ^^^ ^^ ^^^ ^^^ ^^ ^^^ ^^^
>x : number
> : ^^^^^^

declare function fn(x: 'foo'): number;
>fn : { (x: number): string; (x: "foo"): number; }
>fn : { (x: number): string; (x: 'foo'): number; }
> : ^^^ ^^ ^^^ ^^^ ^^ ^^^ ^^^
>x : "foo"
> : ^^^^^
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/ambientExternalModuleWithInternalImportDeclaration.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var c = new A();

=== ambientExternalModuleWithInternalImportDeclaration_0.ts ===
declare module 'M' {
>'M' : Symbol("M", Decl(ambientExternalModuleWithInternalImportDeclaration_0.ts, 0, 0))
>'M' : Symbol('M', Decl(ambientExternalModuleWithInternalImportDeclaration_0.ts, 0, 0))

module C {
>C : Symbol(C, Decl(ambientExternalModuleWithInternalImportDeclaration_0.ts, 0, 20), Decl(ambientExternalModuleWithInternalImportDeclaration_0.ts, 3, 5))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/ambientExternalModuleWithoutInternalImportDeclaration.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var c = new A();

=== ambientExternalModuleWithoutInternalImportDeclaration_0.ts ===
declare module 'M' {
>'M' : Symbol("M", Decl(ambientExternalModuleWithoutInternalImportDeclaration_0.ts, 0, 0))
>'M' : Symbol('M', Decl(ambientExternalModuleWithoutInternalImportDeclaration_0.ts, 0, 0))

module C {
>C : Symbol(C, Decl(ambientExternalModuleWithoutInternalImportDeclaration_0.ts, 0, 20), Decl(ambientExternalModuleWithoutInternalImportDeclaration_0.ts, 3, 5))
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/ambientShorthandFindAllRefs.baseline.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
},
{
"text": "\"jquery\"",
"kind": "stringLiteral"
"kind": "moduleName"
},
{
"text": "\n",
Expand Down Expand Up @@ -106,7 +106,7 @@
},
{
"text": "\"jquery\"",
"kind": "stringLiteral"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this means that writeSymbol call added into the emitter might change how we colorize this quickinfo because of the now attached symbol data in VS (in vscode the quickinfo colorization isn't based on these kinds anymore). Specifically, in the default theme, I think the string's going to be a blue color instead of string color with this? Which seems maybe subjective but less good? I dunno if it matters, and don't actually know if that's still true for VS.

"kind": "moduleName"
},
{
"text": "\n",
Expand Down
6 changes: 5 additions & 1 deletion tests/baselines/reference/api/typescript.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6365,6 +6365,7 @@ declare namespace ts {
OmitParameterModifiers = 8192,
UseAliasDefinedOutsideCurrentScope = 16384,
UseSingleQuotesForStringLiteralType = 268435456,
UseDoubleQuotesForStringLiteralType = 1073741824,
NoTypeReduction = 536870912,
OmitThisParameter = 33554432,
AllowThisInObjectLiteral = 32768,
Expand Down Expand Up @@ -6395,6 +6396,7 @@ declare namespace ts {
OmitParameterModifiers = 8192,
UseAliasDefinedOutsideCurrentScope = 16384,
UseSingleQuotesForStringLiteralType = 268435456,
UseDoubleQuotesForStringLiteralType = 1073741824,
NoTypeReduction = 536870912,
OmitThisParameter = 33554432,
AllowUniqueESSymbolType = 1048576,
Expand All @@ -6404,14 +6406,16 @@ declare namespace ts {
InElementType = 2097152,
InFirstTypeArgument = 4194304,
InTypeAlias = 8388608,
NodeBuilderFlagsMask = 848330095,
NodeBuilderFlagsMask = 1922071919,
}
enum SymbolFormatFlags {
None = 0,
WriteTypeParametersOrArguments = 1,
UseOnlyExternalAliasing = 2,
AllowAnyNodeKind = 4,
UseAliasDefinedOutsideCurrentScope = 8,
UseSingleQuotesForStringLiteralType = 64,
UseDoubleQuotesForStringLiteralType = 128,
}
enum TypePredicateKind {
This = 0,
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/assignmentCompatWithDiscriminatedUnion.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ namespace GH30170 {
> : ^^^^^^^^^^^^^

function drawWithColor(currentColor: 'blue' | 'yellow' | undefined) {
>drawWithColor : (currentColor: "blue" | "yellow" | undefined) => void
>drawWithColor : (currentColor: 'blue' | 'yellow' | undefined) => void
> : ^ ^^ ^^^^^^^^^
>currentColor : "blue" | "yellow"
> : ^^^^^^^^^^^^^^^^^
Expand Down
Loading
Loading