Fix JSDoc typeof parameter resolution #62053
Open
+451
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61959
Summary
This PR fixes inconsistent
typeof
lookup/resolution in JSDoc comments wheretypeof parameterName
would produce "Cannot find name" errors instead of correctly resolving to function parameters.Problem
Previously, when using
typeof
in JSDoc type annotations like@return {typeof a}
, TypeScript would:This inconsistency between type checking and navigation features was confusing for users.
Solution
The fix adds JSDoc parameter resolution logic to the
resolveNameHelper
function inutilities.ts
:typeof
contextsgetHostSignatureFromJSDoc
typeof a
in JSDoc correctly resolves to parameters, matching navigation behaviorKey Changes
src/compiler/utilities.ts
: Added JSDoc parameter resolution inresolveNameHelper
functionsrc/compiler/checker.ts
: Enhanced existing JSDoc parameter resolution logicBefore/After
Before:
After:
Testing
This change ensures consistent behavior between type checking and IDE navigation features, resolving the inconsistency reported in #61959.