-
Notifications
You must be signed in to change notification settings - Fork 12.9k
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main #62068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main #62068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines the diagnostic message for class names when targeting ES5 to clarify that the rule applies to ES5 and above, and propagates that change across multiple localized resource files.
- Updated the internal
ItemId
to use "ES5_and_above" instead of "ES5_with" for clarity. - Revised the English source string to read "Class name cannot be 'Object' when targeting ES5 and above with module {0}."
- Applied matching translation updates in Portuguese, Korean, Japanese, French, Traditional Chinese, and Simplified Chinese.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Portuguese translation for ES5 and above message |
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Korean translation for ES5 and above message |
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Japanese translation for ES5 and above message |
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and French translation for ES5 and above message |
src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Traditional Chinese translation for ES5 and above |
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Simplified Chinese translation for ES5 and above |
@csigs please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main with localized lcls