Skip to content

fix: issues in error handling #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikeshav26 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: issues in error handling #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions demo/web/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,11 @@ async def flush_logs() -> None:
print("Client disconnected (WebSocketDisconnect)")
enqueue_log("client_disconnected")
stop_signal.set()
except Exception as e:
print(f"Error in websocket stream: {e}")
traceback.print_exc()
enqueue_log("backend_error", message=str(e))
stop_signal.set()
finally:
stop_signal.set()
enqueue_log("backend_stream_complete")
Expand All @@ -483,8 +488,11 @@ async def flush_logs() -> None:
log_queue.get_nowait()
except Empty:
break
if ws.client_state == WebSocketState.CONNECTED:
await ws.close()
try:
if ws.client_state == WebSocketState.CONNECTED:
await ws.close()
except Exception as e:
print(f"Error closing websocket: {e}")
print("WS handler exit")
finally:
if acquired:
Expand Down