WSLA: Implement virtioproxy networking mode #13764
Merged
+117
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneBlue
reviewed
Nov 22, 2025
OneBlue
reviewed
Nov 22, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements VirtioProxy networking mode for WSLA (Windows Subsystem for Linux Anywhere), enabling a more efficient networking approach compared to the existing NAT mode. The implementation involved refactoring VirtioNetworking and GnsPortTrackerChannel classes from the service executable into the common library to enable code sharing between WSL and WSLA.
Key Changes:
- Added
WSLANetworkingModeVirtioProxyenum value to the IDL interface - Moved
VirtioNetworkingandGnsPortTrackerChannelfrom service/exe to common library for code reuse - Refactored
VirtioNetworkingconstructor to use callback injection instead of builder pattern - Changed default networking mode for
wsl.exe --wslafrom NAT to VirtioProxy
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/windows/wslaservice/inc/wslaservice.idl | Added VirtioProxy enum value to networking mode definition |
| src/windows/wslaservice/exe/WSLAVirtualMachine.h | Added handler function declarations and DeviceHostProxy member for VirtioProxy support |
| src/windows/wslaservice/exe/WSLAVirtualMachine.cpp | Implemented VirtioProxy networking configuration, device management, and port handling |
| src/windows/service/exe/WslCoreVm.h | Added handler function declarations for VirtioProxy callbacks |
| src/windows/service/exe/WslCoreVm.cpp | Refactored VirtioNetworking initialization to use callback injection pattern and extracted handlers |
| src/windows/service/exe/CMakeLists.txt | Removed VirtioNetworking and GnsPortTrackerChannel from service build (moved to common) |
| src/windows/common/WslClient.cpp | Changed default WSLA networking mode from NAT to VirtioProxy |
| src/windows/common/VirtioNetworking.h | Refactored constructor to accept callbacks directly; removed builder pattern methods |
| src/windows/common/VirtioNetworking.cpp | Updated constructor implementation and callback usage to match new pattern |
| src/windows/common/GnsPortTrackerChannel.h | Added header file to common library (moved from service/exe) |
| src/windows/common/GnsPortTrackerChannel.cpp | Added implementation file to common library (moved from service/exe) |
| src/windows/common/CMakeLists.txt | Added VirtioNetworking and GnsPortTrackerChannel to common library build |
| test/windows/WSLATests.cpp | Added test case to verify VirtioProxy networking functionality |
benhillis
force-pushed
the
user/benhill/wsla_virtio_proxy
branch
from
6549d46 to
003a4bb
Compare
OneBlue
reviewed
Nov 25, 2025
benhillis
force-pushed
the
user/benhill/wsla_virtio_proxy
branch
2 times, most recently
from
9c4061b to
c7082e7
Compare
Copilot finished reviewing on behalf of
benhillis
November 26, 2025 03:40
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 13 changed files in this pull request and generated 3 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ptrivedi
reviewed
Dec 1, 2025
ptrivedi
changed the title
added 2 commits
December 1, 2025 12:58
This change implements the VirtioProxy networking mode for WSLA. This required moving the VirtioProxy and GnsChannel classes into the common library (with NatNetworking). DNS tunneling is currently not supported with this networking mode, so an error is returned. With this change I have updated the default networking move of 'wsl.exe --wsla' to also use VirtioProxy networking mode.
benhillis
force-pushed
the
user/benhill/wsla_virtio_proxy
branch
from
c7082e7 to
60a91b1
Compare
OneBlue
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the VirtioProxy networking mode for WSLA. This required moving the VirtioProxy and GnsChannel classes into the common library (with NatNetworking). I also included the cleanup change to VirtioNetworking that was just merged to main in this PR.
DNS tunneling is currently not supported with this networking mode, so an error is returned. With this change I have updated the default networking move of
wsl.exe --wslato also use VirtioProxy networking mode.