-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved SystemBackdrop sample #1698
base: main
Are you sure you want to change the base?
Conversation
WinUIGallery/SamplePages/SampleBuiltInSystemBackdropsWindow.xaml.cs
Outdated
Show resolved
Hide resolved
WinUIGallery/SamplePages/SampleBuiltInSystemBackdropsWindow.xaml
Outdated
Show resolved
Hide resolved
</StackPanel> | ||
</local:ControlExample> | ||
|
||
<local:ControlExample HeaderText="DesktopAcrylicController:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<local:ControlExample HeaderText="DesktopAcrylicController:" | |
<local:ControlExample HeaderText="DesktopAcrylicController" |
/azp run |
1 similar comment
/azp run |
</local:ControlExample> | ||
|
||
<local:ControlExample HeaderText="DesktopAcrylicController" | ||
CSharpSource="SystemBackdrops\SystemBackdropsSample3.txt"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample code presenter does not display anything for this sample.
WinUIGallery/ContentIncludes.props
Outdated
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSample1_cs.txt" /> | ||
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSample1_xaml.txt" /> | ||
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSample2.txt" /> | ||
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSample3.txt" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, should we give the files more descriptive names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix should also fix the DesktopAcrylicController sample code not being shown.
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSampleBackdropTypes_cs.txt" />
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSampleBackdropTypes_xaml.txt" />
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSampleMicaController.txt" />
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsSampleDesktopAcrylicController.txt" />
<Content Include="ControlPagesSampleCode\SystemBackdrops\SystemBackdropsEnsureSystemDQC.txt" />
Made the sample easier to use.
Description
Motivation and Context
The old sample has no info about how the materials look like.
How Has This Been Tested?
Manual
Screenshots:
Types of changes