Skip to content

Fix build race condition in VS templates #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lauren-ciha wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Fix build race condition in VS templates #6413

Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4c95ea5
First attempt at adding a build guard while packages are installing
lauren-ciha Mar 17, 2026
32a069b
Successful flow with Single-project, C# wapproj flow disabled all builds
lauren-ciha Mar 17, 2026
6f89e42
Adds a check within build button handler to release build guard, afte…
lauren-ciha Mar 17, 2026
1f9fc8d
Add test explorer as a potential build command source for C# unit tes…
lauren-ciha Mar 17, 2026
e0d6066
Add auto-download setting check for smooth exit if disabled
lauren-ciha Mar 17, 2026
f247d50
Add checks for if NuGetRestore is disabled
lauren-ciha Mar 17, 2026
c596799
Add PackageReference fallback for C# projects
lauren-ciha Mar 18, 2026
65c354d
Attempt to add an automatic package download not enabled dialog
lauren-ciha Mar 19, 2026
23b44e0
C++ template shows infobar when auto download disabled
lauren-ciha Mar 20, 2026
9ea5faf
Attempt to eliminate polling
lauren-ciha Mar 20, 2026
40cd26e
Move polling into its own function
lauren-ciha Mar 20, 2026
7a150da
Differentiate C++ message in InfoBar
lauren-ciha Mar 20, 2026
2598c02
Update infobar messages for auto-download disabled case
lauren-ciha Mar 20, 2026
7ae5b8d
Fix BuildGuard logic so infobar shows when builds are attempted
lauren-ciha Mar 20, 2026
afb0a4d
Disable the build guard infobar when build starts
lauren-ciha Mar 20, 2026
38bdd27
Update BuildGuard infobar message to reflect that builds are paused a…
lauren-ciha Mar 20, 2026
9b8cc4c
Add header back to Designer files
lauren-ciha Mar 20, 2026
5730d5a
Link designer files in .csproj for C# and C++ templates
lauren-ciha Mar 20, 2026
49bf795
Remove unused ShowAutomaticPackageDownloadNotEnabledErrorDialog() method
lauren-ciha Mar 20, 2026
46d9733
Remove activity in OnAfterOpenProjects - builds are disabled in RunSt…
lauren-ciha Mar 21, 2026
7537758
Remove SolutionBuildManager2 because we're targeting newer versions o…
lauren-ciha Mar 21, 2026
20a5c92
Remove IVsUpdateSolutionEvents2 and its interfaces because they are n…
lauren-ciha Mar 21, 2026
cf428ed
Update instructions for auto-package instruction to enable both setti…
lauren-ciha Apr 17, 2026
69d7cc8
Add project null check in ProjectFinishedGenerating
lauren-ciha Apr 17, 2026
28dc0ab
Reset source.extension.vsixmanifests to GetVSIXVersion
lauren-ciha Apr 17, 2026
56da5e1
Remove duplicate null check for _solutionBuildManager5
lauren-ciha Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions dev/VSIX/Extension/Cpp/Common/VSPackage.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions dev/VSIX/Extension/Cpp/Common/VSPackage.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,4 +256,13 @@ For more details on the error, check the General tab in the Output window.</valu
<data name="1054" xml:space="preserve">
<value>No output information available.</value>
</data>
<data name="1055" xml:space="preserve">
<value>[{0}] Builds are currently paused while NuGet packages are being installed: {1}. The build will begin once package installation is complete.</value>
</data>
<data name="1056" xml:space="preserve">
<value>[{0}] NuGet package auto-download is disabled. Unable to install: {1}. Click "Manage NuGet Packages" below to install the required packages manually.</value>
</data>
<data name="1057" xml:space="preserve">
<value>[{0}] NuGet package auto-download is disabled. Unable to install: {1}. Click "Manage NuGet Packages" below to install the required packages manually.</value>
</data>
</root>
3 changes: 2 additions & 1 deletion dev/VSIX/Extension/Cpp/Dev17/WindowsAppSDK.Cpp.Extension.Dev17.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@
<Compile Include="..\..\..\Shared\WizardImplementation.cs" Link="WizardImplementation.cs" />
<Compile Include="..\..\..\Shared\WizardInfoBarEvents.cs" Link="WizardInfoBarEvents.cs" />
<Compile Include="..\..\..\Shared\OutputWindowHelper.cs" Link="OutputWindowHelper.cs" />
<Compile Include="..\Common\VSPackage.Designer.cs">
<Compile Include="..\..\..\Shared\BuildGuard.cs" Link="BuildGuard.cs" />
<Compile Include="..\Common\VSPackage.Designer.cs" Link="Resources\VSPackage.Designer.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>VSPackage.resx</DependentUpon>
Expand Down
34 changes: 29 additions & 5 deletions dev/VSIX/Extension/Cs/Common/VSPackage.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion dev/VSIX/Extension/Cs/Common/VSPackage.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,4 +252,13 @@
<data name="1054" xml:space="preserve">
<value>No output information available.</value>
</data>
</root>
<data name="1055" xml:space="preserve">
<value>[{0}] Builds are currently paused while NuGet packages are being installed: {1}. The build will begin once package installation is complete.</value>
</data>
<data name="1056" xml:space="preserve">
<value>[{0}] NuGet package auto-download is disabled. Unable to install: {1}. To resolve, enable "Allow NuGet to download missing packages" and "Automatically check for missing packages during build in Visual Studio" in Tools &gt; Options &gt; NuGet Package Manager and restore the solution, or install the packages manually via the NuGet Package Manager.</value>
</data>
<data name="1057" xml:space="preserve">
<value>[{0}] NuGet package auto-download is disabled. Unable to install: {1}. Click "Manage NuGet Packages" below to install the required packages manually.</value>
</data>
</root>
3 changes: 2 additions & 1 deletion dev/VSIX/Extension/Cs/Dev17/WindowsAppSDK.Cs.Extension.Dev17.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
<Compile Include="..\..\..\Shared\WizardImplementation.cs" Link="WizardImplementation.cs" />
<Compile Include="..\..\..\Shared\WizardInfoBarEvents.cs" Link="WizardInfoBarEvents.cs" />
<Compile Include="..\..\..\Shared\OutputWindowHelper.cs" Link="OutputWindowHelper.cs" />
<Compile Include="..\Common\VSPackage.Designer.cs">
<Compile Include="..\..\..\Shared\BuildGuard.cs" Link="BuildGuard.cs" />
<Compile Include="..\Common\VSPackage.Designer.cs" Link="Resources\VSPackage.Designer.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>VSPackage.resx</DependentUpon>
Expand Down
Loading