-
Notifications
You must be signed in to change notification settings - Fork 433
feat: add IsMonobuild parameter to step templates for self-ref support #6433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kythant
merged 16 commits into
release/dev/monobuild
from
user/kythant/foundation-step-templates-monobuild-aware
Apr 28, 2026
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f9863d8
feat: add IsMonobuild parameter to step templates for self-ref support
kythant 55fa7f8
fix: use @self for monobuild template references
kythant 509bbec
feat: mirror NuGetLicense to BuildAll-expected path when IsMonobuild
kythant 1f2edec
fix: search both candidate paths for NuGetLicense in monobuild mirror
kythant 869eae2
refactor: extract IsMonobuild if/else into wrapper templates
kythant de240bf
fix: fetch NuGetLicense files from monobuild via ADO REST API
kythant 648741e
Revert "fix: fetch NuGetLicense files from monobuild via ADO REST API"
kythant 492d12c
fix: support monobuild Pack with Foundation at s/WindowsAppSDK
kythant cf23b3e
Revert "fix: support monobuild Pack with Foundation at s/WindowsAppSDK"
kythant c34a8ea
remove: NuGetLicense mirror step - files are already at the expected …
kythant c37453e
fix: mirror NuGetLicense + workingDirectory for monobuild Pack
kythant e817455
fix: condition Foundation-relative paths on IsMonobuild
kythant 903e7cf
revert: drop Foundation-relative path conditioning
kythant 47e7c40
Revert "revert: drop Foundation-relative path conditioning"
kythant b118dde
fix: condition DownloadPipelineArtifact targetPath on IsMonobuild
kythant 6a86de5
merge: release/dev/monobuild into user/kythant/foundation-step-templa…
kythant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
build/AzurePipelinesTemplates/WindowsAppSDK-ConvertWttLogToXUnit-Wrapper.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Wrapper for WindowsAppSDK-ConvertWttLogToXUnit-Steps.yml that dispatches to either | ||
| # @WinAppSDK (per-component pipelines) or @self (monobuild) at compile time. | ||
|
|
||
| parameters: | ||
| - name: IsMonobuild | ||
| type: boolean | ||
| default: false | ||
| - name: InnerParams | ||
| type: object | ||
| default: {} | ||
|
|
||
| steps: | ||
| - ${{ if parameters.IsMonobuild }}: | ||
| - template: Build/WindowsAppSDK/AzurePipelinesTemplates/WindowsAppSDK-ConvertWttLogToXUnit-Steps.yml@self | ||
| parameters: ${{ parameters.InnerParams }} | ||
| - ${{ else }}: | ||
| - template: Build/WindowsAppSDK/AzurePipelinesTemplates/WindowsAppSDK-ConvertWttLogToXUnit-Steps.yml@WinAppSDK | ||
| parameters: ${{ parameters.InnerParams }} | ||
18 changes: 18 additions & 0 deletions
18
build/AzurePipelinesTemplates/WindowsAppSDK-DetermineVersion-Wrapper.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Wrapper for WindowsAppSDK-DetermineVersion-Steps.yml that dispatches to either | ||
| # @WinAppSDK (per-component pipelines) or @self (monobuild) at compile time. | ||
|
|
||
| parameters: | ||
| - name: IsMonobuild | ||
| type: boolean | ||
| default: false | ||
| - name: InnerParams | ||
| type: object | ||
| default: {} | ||
|
|
||
| steps: | ||
| - ${{ if parameters.IsMonobuild }}: | ||
| - template: Build/WindowsAppSDK/AzurePipelinesTemplates/WindowsAppSDK-DetermineVersion-Steps.yml@self | ||
| parameters: ${{ parameters.InnerParams }} | ||
| - ${{ else }}: | ||
| - template: Build/WindowsAppSDK/AzurePipelinesTemplates/WindowsAppSDK-DetermineVersion-Steps.yml@WinAppSDK | ||
| parameters: ${{ parameters.InnerParams }} |
19 changes: 19 additions & 0 deletions
19
build/AzurePipelinesTemplates/WindowsAppSDK-EsrpCodeSigning-Wrapper.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Wrapper for WindowsAppSDK-EsrpCodeSigning-Steps.yml that dispatches to either | ||
| # @WinAppSDK (per-component pipelines) or @self (monobuild) at compile time. | ||
| # This eliminates if/else duplication at each call site. | ||
|
|
||
| parameters: | ||
| - name: IsMonobuild | ||
| type: boolean | ||
| default: false | ||
| - name: InnerParams | ||
| type: object | ||
| default: {} | ||
|
|
||
| steps: | ||
| - ${{ if parameters.IsMonobuild }}: | ||
| - template: Build/WindowsAppSDK/AzurePipelinesTemplates/WindowsAppSDK-EsrpCodeSigning-Steps.yml@self | ||
| parameters: ${{ parameters.InnerParams }} | ||
| - ${{ else }}: | ||
| - template: Build/WindowsAppSDK/AzurePipelinesTemplates/WindowsAppSDK-EsrpCodeSigning-Steps.yml@WinAppSDK | ||
| parameters: ${{ parameters.InnerParams }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: unnecessary indentation? The 2 spaces are not required, I think. But that should be ok.
Similar below, not repeating.