Skip to content

Python: Add configurable timeout support to A2AAgent #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Python: Add configurable timeout support to A2AAgent #2432

wants to merge 5 commits into from

Conversation

@giles17
Copy link
Contributor

@giles17 giles17 commented Nov 24, 2025 •
edited
Loading

Motivation and Context

The A2AAgent class had hardcoded timeout values that were insufficient for longer-running A2A operations:

httpx.Timeout(connect=10.0, read=60.0, write=10.0, pool=5.0)
  • Added timeout: float | httpx.Timeout | None = None parameter to A2AAgent.__init__()
  • Added _create_timeout_config() helper method for timeout conversion
  • Added unit tests

Addresses #2407

Description

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings November 24, 2025 20:43
@github-actions github-actions bot changed the title Add configurable timeout support to A2AAgent Python: Add configurable timeout support to A2AAgent Nov 24, 2025
Copilot finished reviewing on behalf of giles17 November 24, 2025 20:45
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Nov 24, 2025 •
edited
Loading

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/a2a/agent_framework_a2a
   _agent.py136794%350–351, 388–389, 418–420
TOTAL15893241684% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2281 130 💤 0 ❌ 0 🔥 56.463s ⏱️

Copilot AI reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

eavanvalkenburg
eavanvalkenburg reviewed Nov 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eavanvalkenburg eavanvalkenburg eavanvalkenburg left review comments

Copilot code review Copilot Copilot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@giles17 @markwallace-microsoft @eavanvalkenburg @dmytrostruk