Improve CLI deployment rendering: symbol fixes, log level helper, render scenarios#16080
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16080Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16080" |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Aspire CLI publish/deployment rendering consistency across platforms by adjusting symbol glyphs, consolidating log-level parsing, and enhancing debug render scenarios.
Changes:
- Force text presentation for common status symbols (✓ ✗ →) and replace the warning glyph to avoid emoji rendering.
- Factor duplicated log-level parsing into a shared
ParseLogLevelhelper returning bothLogLeveland a 3-letter prefix. - Update debug-only render scenarios to escape Spectre markup and add an info-state scenario record.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Cli/Utils/ConsoleActivityLogger.cs | Updates status symbols and adjusts summary rendering comments around Spectre-safe text. |
| src/Aspire.Cli/Commands/RenderCommand.cs | Fixes scenario strings for Spectre markup escaping and adds an Info-state scenario record. |
| src/Aspire.Cli/Commands/PipelineCommandBase.cs | Introduces ParseLogLevel to remove duplicated switch logic and normalize log-level handling. |
| @@ -410,10 +410,10 @@ private void WriteStepDurationsSummary(IReadOnlyList<StepDurationRecord> records | |||
| ActivityState.Failure => _enableColor ? "[red]" + FailureSymbol + "[/]" : FailureSymbol, | |||
There was a problem hiding this comment.
ActivityState.Info isn’t handled in the step-summary symbol mapping, so an info record will render with the in-progress arrow (and cyan) rather than using InfoSymbol/dim styling. Add an explicit ActivityState.Info arm (and consider matching the summary bar colorization) so the new render scenario actually exercises the info symbol as intended.
Suggested change
| ActivityState.Failure => _enableColor ? "[red]" + FailureSymbol + "[/]" : FailureSymbol, | |
| ActivityState.Failure => _enableColor ? "[red]" + FailureSymbol + "[/]" : FailureSymbol, | |
| ActivityState.Info => _enableColor ? "[dim]" + InfoSymbol + "[/]" : InfoSymbol, |
- Add explicit ActivityState.Info arm to step-summary symbol mapping
- Use blue color (instead of dim) for Info state symbols and timeline bars
- Extract GetStateColor helper for consistent state-to-color mapping
- Simplify ColorizeSymbol and ColorizeSummaryBar to delegate to GetStateColor
- Make {bad} bold in publish-summary-markup scenario
davidfowl
approved these changes
Apr 12, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 68 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24299541395 |
radical
pushed a commit
that referenced
this pull request
Apr 14, 2026
This was referenced Apr 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve CLI deployment rendering with several small fixes:
\uFE0E) to✓,✗, and→to force text presentation on all platforms. Replace⚠with△(U+25B3) since VS15 didn't reliably suppress emoji rendering for that character.ParseLogLevelhelper method that returns both theLogLevelenum value and its 3-letter prefix (e.g."TRC","DBG","INF"). Replaces duplicated switch expressions in both the debug and non-debug processing paths. Also handles"INFO"and"WARN"short forms, and mapsnulltoLogLevel.Information.publish-summary-markupscenario data. Add anInfo-state step to thepublish-summary-mixed-hierarchyscenario to exercise theInfoSymbol.Before (warning is emoji instead of text):
After (warning is text):
Checklist