Skip to content

Add TypeScript JavaScript hosting coverage#17057

Merged
sebastienros merged 16 commits into
mainfrom
sebros/ts-js-hosting-coverage
May 19, 2026
Merged

Add TypeScript JavaScript hosting coverage#17057
sebastienros merged 16 commits into
mainfrom
sebros/ts-js-hosting-coverage

Conversation

@sebastienros
Copy link
Copy Markdown
Contributor

@sebastienros sebastienros commented May 13, 2026

Description

Adds JavaScript hosting API coverage for TypeScript polyglot AppHosts. This expands coverage beyond compile/codegen checks so reviewers can validate TypeScript AppHost usage at fixture generation time, local runtime, Docker Compose publish, and a representative Azure Container Apps deployment path.

The change extends the checked-in TypeScript JavaScript hosting fixture with the missing Next.js and publishAs* APIs, adds a CLI E2E scenario that runs multiple JavaScript app types and package managers from a TypeScript AppHost, restores the Docker Compose publish E2E by fixing fixture package metadata and version-prompt handling, and adds a deployment E2E for publishAsStaticWebsite with a Node API target.

Fixes #17037

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Covers TypeScript polyglot JavaScript hosting APIs across compile-time fixture validation, local runtime E2E, Docker Compose publish E2E, and a representative Azure Container Apps deployment E2E.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17057

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17057"

Avoid assuming fixed host ports for Vite and Next.js resources. Verify the actual runtime target port each guest receives so package-manager-specific command arguments can still be exercised reliably.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sebastienros
Copy link
Copy Markdown
Contributor Author

/deployment-test

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #17057...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

@github-actions github-actions Bot had a problem deploying to deployment-testing May 13, 2026 22:23 Failure
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot had a problem deploying to deployment-testing May 13, 2026 22:23 Failure
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot had a problem deploying to deployment-testing May 13, 2026 22:23 Failure
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
@github-actions github-actions Bot temporarily deployed to deployment-testing May 13, 2026 22:23 Inactive
Escape the JMESPath true literal in the endpoint verification command so Bash does not treat it as command substitution before az receives the query.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #17057...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

Use the TypeScript endpoint callback export to set the static website publish endpoint target port and external flag directly. This keeps ACA ingress configured as HTTP while ensuring the endpoint is public for deployment verification.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #17057...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

Create the TypeScript static site HTTP endpoint before publishAsStaticWebsite so the publish helper updates an existing HTTP endpoint instead of creating a TCP endpoint named http. This lets withExternalHttpEndpoints expose the static site correctly for Docker Compose and ACA deployment verification.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #17057...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

sebastienros and others added 3 commits May 14, 2026 13:46
Give each JavaScript runtime fixture a unique fallback port so package-manager-specific argument forwarding does not cause multiple apps to compete for port 3000 during the TypeScript AppHost runtime test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end coverage to validate that TypeScript polyglot AppHosts can consume the JavaScript hosting API surface, including publish APIs and representative CLI/deploy workflows.

Changes:

  • Extends the checked-in TypeScript JavaScript hosting fixture to cover addNextJsApp and publishAs* APIs.
  • Updates CLI E2E coverage to (a) restore Docker Compose publish validation and (b) add a runtime scenario running multiple JS app types/package managers from a TS AppHost.
  • Adds a new deployment E2E that deploys a TS AppHost using publishAsStaticWebsite (with a Node API target) to Azure Container Apps.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/PolyglotAppHosts/Aspire.Hosting.JavaScript/TypeScript/apphost.ts Expands TS fixture coverage for Next.js and publishAs* APIs.
tests/Aspire.Deployment.EndToEnd.Tests/TypeScriptJavaScriptHostingDeploymentTests.cs New ACA deployment E2E for TS AppHost + JS static website publish with API proxy.
tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs Restores/extends CLI E2E scenarios for JS hosting publish + TS runtime usage.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/staticsite/package.json Adds missing package metadata for publish fixture.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/npmscript/package.json Adds missing package metadata for publish fixture.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/npmscript/package-lock.json Aligns lockfile metadata with package.json version.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/nodeserver/package.json Adds missing package metadata for publish fixture.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/nextjs/package.json Adds missing package metadata for publish fixture.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/nextjs/package-lock.json Aligns lockfile metadata with package.json version.
tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/api/package.json Adds missing package metadata for publish fixture.
Files not reviewed (2)
  • tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/nextjs/package-lock.json: Language not supported
  • tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/npmscript/package-lock.json: Language not supported

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 2 jobs were identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Matched test failure patterns (1 test)
  • Aspire.Cli.EndToEnd.Tests.KubernetesDeployBasicApiServiceTests.DeployK8sBasicApiService — Unable to access container registry during publish

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #17057...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

Deployment E2E Tests failed — 35 passed, 1 failed, 0 cancelled

View test results and recordings

View workflow run

Test Result Recording
Deployment.EndToEnd-AzureLogAnalyticsDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-KubernetesGatewayTlsDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureServiceBusDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureStorageDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-NspStorageKeyVaultDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaCompactNamingDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetKeyVaultConnectivityDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-TypeScriptJavaScriptHostingDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetSqlServerInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureKeyVaultDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-TypeScriptExpressDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureEventHubsDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-KubernetesHelmChartDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetSqlServerConnectivityDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureContainerRegistryDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaExistingRegistryDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetKeyVaultInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-TypeScriptVnetSqlServerInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksBlazorRedisDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaStarterDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaDeploymentErrorOutputTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaCustomRegistryDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksMultipleNodePoolsDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureAppConfigDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaManagedRedisDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksStarterDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksVnetInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksVnetWithAzureResourcesDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksWithAzureResourcesDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksStarterWithRedisHelmDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AuthenticationTests ✅ Passed
Deployment.EndToEnd-AppServiceReactDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetStorageBlobInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksWithHelmChartDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetStorageBlobConnectivityDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-FrontDoorDeploymentTests ❌ Failed ▶️ View Recording

@sebastienros
Copy link
Copy Markdown
Contributor Author

/deployment-test

Comment thread tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs Outdated
Comment thread tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread tests/PolyglotAppHosts/Aspire.Hosting.JavaScript/TypeScript/apphost.ts Outdated
…phost.ts

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@IEvangelist
Copy link
Copy Markdown
Member

Code-review only — CI on the latest head isn't fresh, so I read the diff rather than dogfood it.

One bug to flag in the TS polyglot apphost fixture:

tests/PolyglotAppHosts/Aspire.Hosting.JavaScript/TypeScript/apphost.ts (~lines 47–50): the last two calls are missing the . (and are unlikely to do what's intended):

await builder.addJavaScriptApp('node-server-app', './node-server-app')
    publishAsNodeServer('server.js', { outputPath: 'build' });

await builder.addJavaScriptApp('npm-script-app', './npm-script-app')
    publishAsNpmScript({ startScriptName: 'start', runScriptArguments: '-- --port $PORT' });

ASI will insert a semicolon after the addJavaScriptApp(...) call, leaving publishAsNodeServer(...) and publishAsNpmScript(...) as standalone expression statements referencing free functions that don't exist in this module — tsc will emit TS2304: Cannot find name 'publishAsNodeServer' (and same for npm script). Compare with the correct usage in this same PR at tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs:196:

.publishAsNodeServer('build/server.js', { outputPath: 'build' })

Likely intended:

const nodeServerApp = await builder.addJavaScriptApp('node-server-app', './node-server-app');
await nodeServerApp.publishAsNodeServer('server.js', { outputPath: 'build' });

const npmScriptApp = await builder.addJavaScriptApp('npm-script-app', './npm-script-app');
await npmScriptApp.publishAsNpmScript({ startScriptName: 'start', runScriptArguments: '-- --port $PORT' });

Everything else in the diff looked clean — node/vite/nextjs/js apps + lifecycle accessors, static website publish chain (which uses the correct two-statement form), nothing else jumped out. Once the two lines above are fixed this should be good.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

CLI E2E Tests unknown — 94 passed, 0 failed, 2 unknown (commit dbf35cd)

View all recordings
Status Test Recording
AddPackageInteractiveWhileAppHostRunningDetached ▶️ View recording
AddPackageWhileAppHostRunningDetached ▶️ View recording
AgentCommands_AllHelpOutputs_AreCorrect ▶️ View recording
AgentInitCommand_DefaultSelection_InstallsDefaultSkills ▶️ View recording
AgentInitCommand_MigratesDeprecatedConfig ▶️ View recording
AllPublishMethodsBuildDockerImages ▶️ View recording
AspireAddPackageVersionToDirectoryPackagesProps ▶️ View recording
AspireInitSingleFileAppHostRunsViaDotnetRunAppHost ▶️ View recording
AspireInitWithExistingAppHostDirRecreatesMissingNuGetConfigAndPreservesFiles ▶️ View recording
AspireInitWithSolutionFileGeneratesAppHostThatBuildsAgainstChannelHive ▶️ View recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps ▶️ View recording
AspireUpdateRemovesOrphanAppHostPackageVersionWhenSdkAlreadyCurrent ▶️ View recording
Banner_DisplayedOnFirstRun ▶️ View recording
Banner_DisplayedWithExplicitFlag ▶️ View recording
Banner_NotDisplayedWithNoLogoFlag ▶️ View recording
CertificatesClean_RemovesCertificates ▶️ View recording
CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate ▶️ View recording
CertificatesTrust_WithUntrustedCert_TrustsCertificate ▶️ View recording
ConfigSetGet_CreatesNestedJsonFormat ▶️ View recording
CreateAndRunAspireStarterProject ▶️ View recording
CreateAndRunAspireStarterProjectWithBundle ▶️ View recording
CreateAndRunEmptyAppHostProject ▶️ View recording
CreateAndRunJavaEmptyAppHostProject ▶️ View recording
CreateAndRunJsReactProject ▶️ View recording
CreateAndRunPythonReactProject ▶️ View recording
CreateAndRunTypeScriptEmptyAppHostProject ▶️ View recording
CreateAndRunTypeScriptStarterProject ▶️ View recording
CreateJavaAppHostWithViteApp ▶️ View recording
CreateTypeScriptAppHostWithViteApp_UsesConfiguredToolchain ▶️ View recording
DashboardRunWithOtelTracesReturnsNoTraces ▶️ View recording
DeployK8sBasicApiService ▶️ View recording
DeployK8sWithExternalHelmChart ▶️ View recording
DeployK8sWithGarnet ▶️ View recording
DeployK8sWithMongoDB ▶️ View recording
DeployK8sWithMySql ▶️ View recording
DeployK8sWithPostgres ▶️ View recording
DeployK8sWithRabbitMQ ▶️ View recording
DeployK8sWithRedis ▶️ View recording
DeployK8sWithSqlServer ▶️ View recording
DeployK8sWithValkey ▶️ View recording
DeployTypeScriptAppToKubernetes ▶️ View recording
DescribeCommandResolvesReplicaNames ▶️ View recording
DescribeCommandShowsRunningResources ▶️ View recording
DetachFormatJsonProducesValidJson ▶️ View recording
DetachFormatJsonProducesValidJsonWhenRestartingExistingInstance ▶️ View recording
DoListStepsShowsPipelineSteps ▶️ View recording
DocsCommand_RendersInteractiveMarkdownFromLocalSource ▶️ View recording
DoctorCommand_DetectsDeprecatedAgentConfig ▶️ View recording
DoctorCommand_TypeScriptAppHostReportsMissingConfiguredToolchain ▶️ View recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View recording
GlobalMigration_HandlesCommentsAndTrailingCommas ▶️ View recording
GlobalMigration_HandlesMalformedLegacyJson ▶️ View recording
GlobalMigration_PreservesAllValueTypes ▶️ View recording
GlobalMigration_SkipsWhenNewConfigExists ▶️ View recording
GlobalSettings_MigratedFromLegacyFormat ▶️ View recording
InitTypeScriptAppHost_AugmentsExistingViteRepoAtRoot ▶️ View recording
InteractiveCSharpInitCreatesExpectedFiles ▶️ View recording
InvalidAppHostPathWithComments_IsHealedOnRun ▶️ View recording
JavaScriptHostingApisRunFromTypeScriptAppHost ▶️ View recording
LatestCliCanStartStableChannelAppHost ▶️ View recording
LatestCliCanStartStableChannelTypeScriptAppHost ▶️ View recording
LegacySettingsMigration_AdjustsRelativeAppHostPath ▶️ View recording
LogLevelTrace_ProducesTraceEntriesInCliLogFile ▶️ View recording
LogsCommandShowsResourceLogs ▶️ View recording
OtelLogsReturnsStructuredLogsFromStarterApp ▶️ View recording
OtelLogsReturnsStructuredLogsFromStarterAppIsolated ▶️ View recording
PsCommandListsRunningAppHost ▶️ View recording
PsFormatJsonOutputsOnlyJsonToStdout ▶️ View recording
PublishWithConfigureEnvFileUpdatesEnvOutput ▶️ View recording
PublishWithDockerComposeServiceCallbackSucceeds ▶️ View recording
PublishWithoutOutputPathUsesAppHostDirectoryDefault ▶️ View recording
ResourceCommand_FailedExecution_DisplaysAppHostLogPathAndLogContainsEntries ▶️ View recording
ResourceCommand_FailsWhenInteractionServiceIsRequired ▶️ View recording
ResourceCommand_SetAndDeleteParameterUpdatesDescribeOutput ▶️ View recording
RestoreGeneratesSdkFiles ▶️ View recording
RestoreGeneratesSdkFiles_WithConfiguredToolchain ▶️ View recording
RestoreRefreshesGeneratedSdkAfterAddingIntegration ▶️ View recording
RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes ▶️ View recording
RunFromParentDirectory_UsesExistingConfigNearAppHost ▶️ View recording
RunPublishFailureScenarioAsync ▶️ View recording
RunReportsSyntaxErrorsForDotNetAppHost ▶️ View recording
RunReportsSyntaxErrorsForTypeScriptAppHost ▶️ View recording
SecretCrudOnDotNetAppHost ▶️ View recording
SecretCrudOnTypeScriptAppHost ▶️ View recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels ▶️ View recording
StartAndWaitForTypeScriptSqlServerAppHostWithNativeAssets ▶️ View recording
StartReportsSyntaxErrorsForDotNetAppHost ▶️ View recording
StartReportsSyntaxErrorsForTypeScriptAppHost ▶️ View recording
StopAllAppHostsFromAppHostDirectory ▶️ View recording
StopJavaPolyglotAppHostUsingApphostDirectory ▶️ View recording
StopNonInteractiveSingleAppHost ▶️ View recording
StopTypeScriptPolyglotAppHostUsingApphostDirectory ▶️ View recording
StopWithNoRunningAppHostExitsSuccessfully ▶️ View recording
UnAwaitedChainsCompileWithAutoResolvePromises ▶️ View recording
UpdateProjectChannelToStable_TypeScript_PicksUpStablePackages ▶️ View recording

📹 Recordings uploaded automatically from CI run #26110452861

@aspire-repo-bot
Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

docs_optional → test_only

No triggered signals (signal_count == 0); only_test_or_build_changes: true.

All 10 changed files are under tests/:

  • tests/Aspire.Cli.EndToEnd.Tests/Fixtures/JsPublish/** (package.json / package-lock.json fixture files)
  • tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs (new CLI E2E test)
  • tests/Aspire.Deployment.EndToEnd.Tests/TypeScriptJavaScriptHostingDeploymentTests.cs (new deployment E2E test)
  • tests/PolyglotAppHosts/Aspire.Hosting.JavaScript/TypeScript/apphost.ts (TypeScript AppHost test fixture)

No new public API, CLI flags, configuration keys, or user-visible behavior was introduced. The PR adds test coverage for existing JavaScript hosting APIs. No documentation update is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand TypeScript coverage for JavaScript hosting APIs

4 participants