Route DisplayError output to stderr consistently#17230
Merged
Merged
Conversation
DisplayError now always writes to _errorConsole (stderr) instead of following the MessageConsole property which defaults to stdout. This ensures error messages are visible when stdout is redirected. Extracted a shared WriteEmojiMessage helper to avoid code duplication between DisplayError and DisplayMessage. Fixes microsoft#16136
ellahathaway
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17230Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17230" |
JamesNK
approved these changes
May 19, 2026
Member
|
Thanks! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16136
DisplayErrorrouted throughMessageConsole, which defaults to stdout. Errors only went to stderr as a side effect of--output jsonmode. This fix makesDisplayErroralways write to_errorConsole(stderr) directly.Repro (before fix):
After fix: