Add TypeScript deployment coverage gaps#17319
Merged
sebastienros merged 1 commit intoMay 21, 2026
Merged
Conversation
Cover Azure Container App jobs and Kubernetes service/custom manifest publishing from TypeScript deployment tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17319Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17319" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds targeted deployment E2E coverage for previously type-check-only TypeScript publish paths, and documents what remains intentionally uncovered to keep the deployment validation map explicit.
Changes:
- Adds a new Azure Container Apps Jobs deployment E2E test for TypeScript AppHosts, validating manual vs scheduled trigger configuration.
- Extends the existing TypeScript AKS + cert-manager deployment E2E to also validate
publishAsKubernetesServiceand a customConfigMapemitted viaaddManifest. - Documents a TypeScript deployment coverage matrix plus intentional gaps in the deployment E2E README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Deployment.EndToEnd.Tests/TypeScriptAzureContainerAppJobDeploymentTests.cs | New TypeScript ACA Jobs deployment E2E validating deployed job trigger shape via az containerapp job list. |
| tests/Aspire.Deployment.EndToEnd.Tests/AksAzureKubernetesEnvironmentCertManagerTypeScriptDeploymentTests.cs | Extends TypeScript AKS deployment E2E to include Kubernetes service publishing and custom manifest verification. |
| tests/Aspire.Deployment.EndToEnd.Tests/README.md | Adds TypeScript deployment coverage matrix and documents intentional gaps. |
Member
PR Testing ReportPR Information
CLI Version Verification
Changes AnalyzedThis PR only changes deployment end-to-end test coverage and documentation:
Test Scenarios ExecutedScenario 1: Dogfood CLI install and version checkObjective: Verify the PR dogfood artifact is available and corresponds to the current PR head. Result: Passed Evidence:
Scenario 2: Deployment E2E executionObjective: Validate the changed Azure deployment E2E coverage. Result: Not run in this local PR-testing pass Reason: The changed tests are deployment end-to-end tests that require Azure deployment infrastructure/credentials. I did not run Azure deployment tests from this local agent environment. The PR does not change product runtime code or CLI behavior that can be meaningfully validated with a local dogfood CLI scenario. Summary
Overall ResultArtifact verified; deployment test execution not run locally. No local product-code scenario was applicable because the PR only changes Azure deployment E2E tests and their coverage documentation. |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
❓ CLI E2E Tests unknown — 95 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26185764515 |
davidfowl
approved these changes
May 21, 2026
Contributor
|
✅ No documentation update needed. docs_optional → test_only: No documentation PR is needed. All 3 changed files are under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypeScript publish APIs were type-checked in the polyglot apphosts, but several deployment-facing paths did not have real Azure validation or documented gaps. This adds focused deployment coverage for the highest-value Azure Container Apps and Kubernetes gaps and records the remaining intentional gaps so future changes have a clear coverage map.
The change adds a TypeScript Azure Container App Jobs E2E test for manual and scheduled job trigger configuration, extends the existing TypeScript AKS cert-manager test to also validate
publishAsKubernetesServiceplus a custom ConfigMap manifest, and documents the TypeScript deployment coverage matrix in the deployment E2E README.Fixes: #17039
Checklist
<remarks />and<code />elements on your triple slash comments?