Skip to content

Improve page titles by adding (resource) or (trace name) where appropriate. - #6970

Merged
James Newton-King (JamesNK) merged 5 commits into
microsoft:mainfrom
adamint:dev/adamint/improve-titles
Jan 28, 2025
Merged

Improve page titles by adding (resource) or (trace name) where appropriate.#6970
James Newton-King (JamesNK) merged 5 commits into
microsoft:mainfrom
adamint:dev/adamint/improve-titles

Conversation

@adamint

@adamint Adam Ratzman (adamint) commented Dec 19, 2024

Copy link
Copy Markdown
Member

Description

Updates console log/traces/metrics/structured logs page titles to include the resource, replica set, or trace span name where set, to show more information.

Also renames ApplicationName to AspirePageTitle because the component allows for additional text alongside the application name.

Fixes #5672

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@adamint

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/Aspire.Dashboard/Components/Pages/TraceDetail.razor Outdated
Comment thread src/Aspire.Dashboard/Components/Pages/Metrics.razor Outdated
Comment thread src/Aspire.Dashboard/Components/Controls/ApplicationName.razor.cs Outdated
Comment thread src/Aspire.Dashboard/Components/Controls/ApplicationName.razor.cs Outdated
@JamesNK

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
James Newton-King (JamesNK) merged commit 8325ed5 into microsoft:main Jan 28, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard : Resource Name as Title for Log pages

3 participants