Upgrade vss api netcore version, has BuildXL changes (#4220)

* Upgrade vss api netcore version, has BuildXL changes * Adding Nuget authenticate task * Nuget auth task before the build * Try v0 * Remove nuget auth task * Nuget auth * Remove auth task * Remove redundant security package declaration * Adding System.Security.Cryptography.ProtectedData back * Adding cred provider * Removing redundant system.buffers reference * Supress warnings * Remove unused variable * Removing HashType.64k hardcoding
microsoft · Apr 24, 2023 · 7778d90 · 7778d90
1 parent e54db88
commit 7778d90
Show file tree

Hide file tree

Showing 12 changed files with 17 additions and 13 deletions.
diff --git a/src/Agent.Listener/Agent.Listener.csproj b/src/Agent.Listener/Agent.Listener.csproj
@@ -4,6 +4,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Agent.PluginHost/Agent.PluginHost.csproj b/src/Agent.PluginHost/Agent.PluginHost.csproj
@@ -4,6 +4,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Agent.Plugins/Agent.Plugins.csproj b/src/Agent.Plugins/Agent.Plugins.csproj
@@ -4,6 +4,7 @@
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Agent.Sdk/Agent.Sdk.csproj b/src/Agent.Sdk/Agent.Sdk.csproj
@@ -3,15 +3,14 @@
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8" Condition="$(CodeAnalysis)=='true'" />
     <PackageReference Include="Microsoft.Win32.Registry" Version="4.7.0" />
-    <PackageReference Include="System.Security.Cryptography.ProtectedData" Version="4.7.0" />
     <PackageReference Include="System.ServiceProcess.ServiceController" Version="4.4.0" />
     <PackageReference Include="System.Text.Encoding.CodePages" Version="4.4.0" />
-    <PackageReference Include="System.Security.Cryptography.Cng" Version="4.5.0" />
     <PackageReference Include="vss-api-netcore" Version="$(VssApiVersion)" />
   </ItemGroup>
 </Project>
diff --git a/src/Agent.Sdk/Util/PlatformUtil.cs b/src/Agent.Sdk/Util/PlatformUtil.cs
@@ -391,7 +391,7 @@ public static bool DetectDockerContainer()
                     }
                 }
             }
-            catch (Exception ex)
+            catch (Exception)
             {
                 // Logging exception will be handled by JobRunner
                 throw;
@@ -411,7 +411,7 @@ public static bool DetectAzureVM()
                 if (metadataProvider.HasMetadata())
                     isAzureVM = true;
             }
-            catch (Exception ex)
+            catch (Exception)
             {
                 // Logging exception will be handled by JobRunner
                 throw;

diff --git a/src/Agent.Worker/Agent.Worker.csproj b/src/Agent.Worker/Agent.Worker.csproj
@@ -4,6 +4,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <ItemGroup>
@@ -14,7 +15,6 @@
   <ItemGroup>
     <PackageReference Include="Azure.Identity" Version="1.6.1" />
     <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8" Condition="$(CodeAnalysis)=='true'" />
-    <PackageReference Include="System.Security.Cryptography.ProtectedData" Version="4.7.0" />
     <PackageReference Include="System.ServiceProcess.ServiceController" Version="4.4.0" />
     <PackageReference Include="vss-api-netcore" Version="$(VssApiVersion)" />
   </ItemGroup>

diff --git a/src/Common.props b/src/Common.props
@@ -10,7 +10,7 @@
     <OSPlatform>OS_UNKNOWN</OSPlatform>
     <OSArchitecture>ARCH_UNKNOWN</OSArchitecture>
     <DebugConstant></DebugConstant>
-    <VssApiVersion>0.5.181-private</VssApiVersion>
+    <VssApiVersion>0.5.183-private</VssApiVersion>
     <CodeAnalysis>$(CodeAnalysis)</CodeAnalysis>
   </PropertyGroup>
 

diff --git a/src/Microsoft.VisualStudio.Services.Agent/Blob/BlobFileInfo.cs b/src/Microsoft.VisualStudio.Services.Agent/Blob/BlobFileInfo.cs
@@ -13,7 +13,7 @@ public DedupIdentifier DedupId
         {
             get
             {
-                return Node.GetDedupIdentifier(HashType.Dedup64K);
+                return Node.GetDedupIdentifier();
             }
         }
         public bool Success { get; set; }

diff --git a/src/Microsoft.VisualStudio.Services.Agent/Blob/BlobStoreUtils.cs b/src/Microsoft.VisualStudio.Services.Agent/Blob/BlobStoreUtils.cs
@@ -43,7 +43,7 @@ public static class BlobStoreUtils
             foreach (var file in fileNodes.Where(x => x.Success))
             {
                 // ChunkHelper uses 64k block default size
-                var dedupId = file.Node.GetDedupIdentifier(HashType.Dedup64K);
+                var dedupId = file.Node.GetDedupIdentifier();
                 fileDedupIds[dedupId] = file.Path;
             }
 
@@ -180,7 +180,7 @@ private static DedupNode CreateNodeToUpload(IEnumerable<DedupNode> nodes)
             var chunk = await ChunkerHelper.CreateFromFileAsync(FileSystem.Instance, itemPath, cancellationToken, false);
             var rootNode = new DedupNode(new[] { chunk });
             // ChunkHelper uses 64k block default size
-            var dedupId = rootNode.GetDedupIdentifier(HashType.Dedup64K);
+            var dedupId = rootNode.GetDedupIdentifier();
 
             // Setup upload session to keep file for at mimimum one day
             // Blobs will need to be associated with the server with an ID ref otherwise they will be

diff --git a/src/Microsoft.VisualStudio.Services.Agent/Microsoft.VisualStudio.Services.Agent.csproj b/src/Microsoft.VisualStudio.Services.Agent/Microsoft.VisualStudio.Services.Agent.csproj
@@ -4,6 +4,7 @@
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <ItemGroup>
@@ -13,8 +14,6 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8" Condition="$(CodeAnalysis)=='true'" />
     <PackageReference Include="Microsoft.Win32.Registry" Version="4.7.0" />
-    <PackageReference Include="System.Security.Cryptography.Cng" Version="4.5.0" />
-    <PackageReference Include="System.Security.Cryptography.ProtectedData" Version="4.7.0" />
     <PackageReference Include="System.Text.Encoding.CodePages" Version="4.4.0" />
     <PackageReference Include="vss-api-netcore" Version="$(VssApiVersion)" />
   </ItemGroup>

diff --git a/src/Test/L1/Mock/FakeJobServer.cs b/src/Test/L1/Mock/FakeJobServer.cs
@@ -142,7 +142,7 @@ public Task<BlobIdentifierWithBlocks> UploadLogToBlobStore(Stream blob, string h
             UploadedAttachmentBlobFiles.Add(itemPath);
             var chunk = await ChunkerHelper.CreateFromFileAsync(FileSystem.Instance, itemPath, cancellationToken, false);
             var rootNode = new DedupNode(new[] { chunk });
-            var dedupId = rootNode.GetDedupIdentifier(HashType.Dedup64K);
+            var dedupId = rootNode.GetDedupIdentifier();
 
             return (dedupId, rootNode.TransitiveContentBytes);
         }

diff --git a/src/Test/Test.csproj b/src/Test/Test.csproj
@@ -8,13 +8,16 @@
     <ProjectReference Include="..\Agent.Sdk\Agent.Sdk.csproj" />
   </ItemGroup>
 
+  <PropertyGroup>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="azuredevops-testresultparser" Version="1.0.2" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
     <PackageReference Include="Microsoft.CodeCoverage" Version="16.4.0" />
     <PackageReference Include="Microsoft.TestPlatform.TestHost" Version="16.4.0" GeneratePathProperty="true" />
     <PackageReference Include="Moq" Version="4.6.36-alpha" />
-    <PackageReference Include="System.Buffers" Version="4.3.0" />
     <PackageReference Include="System.Reflection.TypeExtensions" Version="4.4.0" />
     <PackageReference Include="System.Threading.ThreadPool" Version="4.3.0" />
     <PackageReference Include="vss-api-netcore" Version="$(VssApiVersion)" />
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,7 +13,7 @@ public DedupIdentifier DedupId @@
             {
                 get
                 {
-                    return Node.GetDedupIdentifier(HashType.Dedup64K);
+                    return Node.GetDedupIdentifier();
                 }
             }
             public bool Success { get; set; }
@@ Expand Down @@