Skip to content

Conversation

AlexVTor
Copy link
Contributor

@AlexVTor AlexVTor commented Sep 3, 2025

Context

AB#{2313691}

This PR address a bug where the FeedUrl input parameter causes the task to fail if not present alongside a WIF Service Connection. This parameter was unused in non-WIF versions of the task but is checked in WIF versions of the task.

As we are beginning the rollout, we should ensure this isn't a breaking scenario.
Fail when: NuGet and WIF Service Connections are both used
Warn when: (Regardless of Nuget Input) WIF Service Connection is not set, but FeedUrl is


Task Name

NuGetAuthenticateV1

Description


When the FeedUrl parameter is set, and a WIF service connection is not set, we currently fail the task. This is breaking behavior that some customers may have faulted themselves into.

The changes in this PR include changes to stop failing in the scenario described above, and instead, warn that the FeedUrl parameter is being ignored. This is a mitigation for users that would otherwise be broken.

Error messaging has been included as part of these changes.
Telemetry has been added to give a signal and direct our roadmap to ultimately shift users off this code path.

Risk Assessment (Low / Medium / High)


Medium - We change the behavior of the task from failing to succeeding

Change Behind Feature Flag (Yes / No)


No - This is a mitigation for an active issue for a small group of customers in production

Tech Design / Approach


Design has been written and reviewed: Y

Documentation Changes Required (Yes/No)


Y

Unit Tests Added or Updated (Yes / No)


N/A

Additional Testing Performed


Manual
Integration
Scenario

Logging Added/Updated (Yes/No)


  • Appropriate log statements are added with meaningful messages: Y
  • Logging does not expose sensitive data: Y
  • Log levels are used correctly (e.g., info, warn, error): Y

Telemetry Added/Updated (Yes/No)


  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)


  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)


  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.
    Y

Checklist

  • [Y] Related issue linked (if applicable)
  • [Y] Task version was bumped — see versioning guide
  • [Y] Verified the task behaves as expected

@AlexVTor AlexVTor requested a review from a team as a code owner September 3, 2025 00:20
@AlexVTor AlexVTor changed the title NuGet Authentication: WIF Parameter bugfix NuGet Authentication Bugfix: Stop Failing when FeedUrl is Provided Sep 3, 2025
@AlexVTor
Copy link
Contributor Author

AlexVTor commented Sep 5, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlexVTor
Copy link
Contributor Author

AlexVTor commented Sep 5, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlexVTor AlexVTor merged commit d71f376 into master Sep 5, 2025
11 checks passed
@AlexVTor AlexVTor deleted the users/alextorres/NuGetAuthFeedUrlHotfix branch September 5, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants