-
Notifications
You must be signed in to change notification settings - Fork 2.7k
NuGet Authentication Bugfix: Stop Failing when FeedUrl is Provided #21288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embetten
reviewed
Sep 3, 2025
embetten
reviewed
Sep 3, 2025
embetten
reviewed
Sep 3, 2025
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
embetten
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AB#{2313691}
This PR address a bug where the FeedUrl input parameter causes the task to fail if not present alongside a WIF Service Connection. This parameter was unused in non-WIF versions of the task but is checked in WIF versions of the task.
As we are beginning the rollout, we should ensure this isn't a breaking scenario.
Fail when: NuGet and WIF Service Connections are both used
Warn when: (Regardless of Nuget Input) WIF Service Connection is not set, but FeedUrl is
Task Name
NuGetAuthenticateV1
Description
When the FeedUrl parameter is set, and a WIF service connection is not set, we currently fail the task. This is breaking behavior that some customers may have faulted themselves into.
The changes in this PR include changes to stop failing in the scenario described above, and instead, warn that the FeedUrl parameter is being ignored. This is a mitigation for users that would otherwise be broken.
Error messaging has been included as part of these changes.
Telemetry has been added to give a signal and direct our roadmap to ultimately shift users off this code path.
Risk Assessment (Low / Medium / High)
Medium - We change the behavior of the task from failing to succeeding
Change Behind Feature Flag (Yes / No)
No - This is a mitigation for an active issue for a small group of customers in production
Tech Design / Approach
Design has been written and reviewed: Y
Documentation Changes Required (Yes/No)
Y
Unit Tests Added or Updated (Yes / No)
N/A
Additional Testing Performed
Manual
Integration
Scenario
Logging Added/Updated (Yes/No)
Telemetry Added/Updated (Yes/No)
Rollback Scenario and Process (Yes/No)
Dependency Impact Assessed and Regression Tested (Yes/No)
Y
Checklist