Adding build/test commands in scripts section of existing package.json #21292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaveshbhati
requested review from
tarunramsinghani,
a team,
DergachevE,
carl-tanner,
fadnavistanmay,
b-barthel,
kunalkaroth,
manolerazvan,
jvano,
dannysongg,
mkarmark,
joslinmicrosoft,
ShilpiRachna1,
marianan,
FinVamp1,
patelchandni,
cormacpayne,
daniv-msft,
imenkov and
lucen-ms
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bhaveshbhati
requested review from
JeyJeyGao and
YevheniiKholodkov
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bhaveshbhati
changed the title
tarunramsinghani
approved these changes
Sep 9, 2025
manolerazvan
approved these changes
Sep 9, 2025
DergachevE
approved these changes
Sep 9, 2025
tarunramsinghani
deleted the
users/bhatibhavesh/addbuildtestcommands
branch
|
Bypassing the checks as this is build infra change only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Parent work item: Task Lifecycle: Engineering: Improve management of common packages
https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/2121133/
Current Task: Adding build command in scripts section of existing package.json
https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/2314422
As part of this initiative, we are working on improving the overall time it takes to build all the tasks. In that we are going to use pnpm workspace as utility to run the build across Tasks parallelly. So, this is prep work for that.
Info here: Doc Link
Linux : https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=30446580&view=logs&j=05b67fdb-d1c9-5a4b-d858-7cd64b2ec096
MacOS: https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=30450715&view=logs&j=1be05aa8-f92f-5ba4-808f-064b8d3541e9&t=45118c50-c153-513e-f3d0-3cb6ef31087a
Windows: https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=30440474&view=results
cli-tests-task-v2
https://dev.azure.com/canarytest/PipelineTasks/_build/results?buildId=194950&view=logs&j=11bb91bb-611c-5ef4-8bab-f9fc463fe391&t=bb5a2984-3ef2-58e6-9d2c-9f94286532bc&s=d654deb9-056d-50a2-1717-90c08683d50a
Task Name
Multiple Tasks
Description
In this PR, adding the build command to the Tasks where package.json already exists. It should not change anything from the Task perspective so bumping of Task version is not required.
Risk Assessment (Low / Medium / High)
Low - Since we are only adding the build command in scripts in package.json. Our current build system doesn't use this info in anyway. So, it should be safe.
Change Behind Feature Flag (Yes / No)
No
Tech Design / Approach
Info here: Doc Link
Documentation Changes Required (Yes/No)
No
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Logging Added/Updated (Yes/No)
No
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
Revert PR
Dependency Impact Assessed and Regression Tested (Yes/No)
Yes
Checklist