Fix NumberPad buttons being misaligned #2376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s parent The NumberPad now looks at the parent grid, grabs the width of the columns, and applies it to its own columns. This eliminates the misaligned buttons in NumberPad on window resize.
|
@microsoft-github-policy-service agree |
|
Thank you, our lord and savior, for fixing the damned misalignment. I can't believe it took 218 lines of code holy hell but Microsoft should hire you man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #2182
PR fixes issue #2182, which has multiple unreported duplicates at the time of writing.
Description of the changes:
The NumberPad now looks at the parent grid, grabs the width of the columns, and applies it to its own columns. This eliminates the misaligned buttons in NumberPad on window resize.
How changes were validated:
The changes can be observed in the UI by looking at it. (This has been checked on all available DPI presets in the windows settings.)
Testing:
Specify how you tested your changes (i.e. manual/ad-hoc testing, automated testing, new automated tests added)-->