-
Notifications
You must be signed in to change notification settings - Fork 115
Spelling #1048
base: master
Are you sure you want to change the base?
Spelling #1048
Changes from all commits
c88bd24
62ebbdb
5809aaf
97ff00b
b2d5c07
8943aef
5c8e744
64b9fa7
52bb551
c50ae23
8f8805e
2e78c8a
7b73061
2caee9c
8a85f1d
465aef2
3119966
93e64d7
a63591f
114a67f
8824608
bacd70a
890170c
8faec8f
c38eba6
2e36077
f952a91
1cbc1bc
b4176dc
b267542
f510030
2c73a27
e62aa11
db2fe3c
6240eec
1786980
23ec3a0
57f2a3f
8878089
1fb5a07
dcec8bc
3d8f93d
6ca5cfe
1dbacef
94c7362
6690c13
482a312
e6d8450
6c305d9
7fb4124
32a14f4
a448c0c
f3dfed2
f9b86ed
0f26eda
13ccf8a
273a59b
7d1223a
bfd3a7b
d8ed3e7
2fbc1ef
bd7bf51
74686b2
21d8d90
a052081
71bfba1
7247cf2
a25a4bc
350ae23
45e49bc
d2f47a4
e4370de
539fce6
30fbe86
b5372d9
6356065
1067327
5c550bf
c5d03bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,7 +87,7 @@ You can add custom sample datasets that can be used with Charticulator. To do s | |
| [ | ||
| { | ||
| "name": "<Your dataset display name>", | ||
| "description": "<Your dataset desription>", | ||
| "description": "<Your dataset description>", | ||
| "tables": [ | ||
| { | ||
| "name": "<Your dataset file name without extension>", | ||
|
|
@@ -128,6 +128,6 @@ contact [[email protected]](mailto:[email protected]) with any additio | |
| # Documentation | ||
|
|
||
| Run `yarn typedoc` to generate documentation pages. | ||
| The page will be awailable in [`./docs/charticulator`](./docs/charticulator/index.html) | ||
| The page will be available in [`./docs/charticulator`](./docs/charticulator/index.html) | ||
|
|
||
| Start point of documentation is index page {@link "index"} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ import { EditorType } from "./stores/app_store"; | |
| import { LocalizationConfig } from "../container/container"; | ||
|
|
||
| export class ApplicationExtensionContext implements ExtensionContext { | ||
| constructor(public app: Application) {} | ||
| constructor(public app: Application) { } | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't do this. But I apparently opened this file in VSCode and some reformatting rule apparently insisted (it also rewrote my workflow yaml). I'm willing to drop these changes, but do note that files should not trip up drive-by-contributors which means someone should really clean up the codebase so this doesn't happen when the next person drives by. |
||
|
|
||
| public getGlobalDispatcher(): Dispatcher<Action> { | ||
| return this.app.appStore.dispatcher; | ||
|
|
@@ -125,7 +125,7 @@ export class Application { | |
| workerScriptContent?: string; | ||
| worker?: CharticulatorWorkerInterface; | ||
| }, | ||
| localizaiton: LocalizationConfig, | ||
| localization: LocalizationConfig, | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possible this is a public api. I hope it isn't... |
||
| handlers?: { | ||
| menuBarHandlers?: MenuBarHandlers; | ||
| telemetry?: TelemetryRecorder; | ||
|
|
@@ -175,7 +175,7 @@ export class Application { | |
| ); | ||
| const DelimiterSymbol = parseSafe( | ||
| window.localStorage.getItem(LocalStorageKeys.DelimiterSymbol) || | ||
| defaultDelimiter, | ||
| defaultDelimiter, | ||
| defaultDelimiter | ||
| ); | ||
| const GroupSymbol = parseSafe( | ||
|
|
@@ -184,7 +184,7 @@ export class Application { | |
| ); | ||
| const NumberFormatRemove = parseSafe( | ||
| window.localStorage.getItem(LocalStorageKeys.NumberFormatRemove) || | ||
| defaultNumberFormat.remove, | ||
| defaultNumberFormat.remove, | ||
| defaultNumberFormat.remove | ||
| ); | ||
|
|
||
|
|
@@ -205,13 +205,13 @@ export class Application { | |
| }); | ||
| } catch (ex) { | ||
| setFormatOptions({ | ||
| currency: [localizaiton?.currency, ""] ?? defaultCurrency, | ||
| currency: [localization?.currency, ""] ?? defaultCurrency, | ||
| grouping: defaultDigitsGroup, | ||
| decimal: localizaiton?.decemalDelimiter ?? defaultNumberFormat.decimal, | ||
| decimal: localization?.decimalDelimiter ?? defaultNumberFormat.decimal, | ||
| thousands: | ||
| localizaiton?.thousandsDelimiter ?? defaultNumberFormat.decimal, | ||
| localization?.thousandsDelimiter ?? defaultNumberFormat.decimal, | ||
| }); | ||
| console.warn("Loadin localization settings failed"); | ||
| console.warn("Loading localization settings failed"); | ||
| } | ||
|
|
||
| (window as any).mainStore = this.appStore; | ||
|
|
@@ -283,7 +283,7 @@ export class Application { | |
| deepClone(info.specification) | ||
| ); | ||
|
|
||
| // if version wasn't saved in tempalte we asume it is 2.0.3 | ||
| // if version wasn't saved in template we assume it is 2.0.3 | ||
| if (info.template && info.template.version == undefined) { | ||
| info.template.version = defaultVersionOfTemplate; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,4 +18,4 @@ export * from "./gradient_picker"; | |
| export * from "./minimizable_panel"; | ||
| export * from "./error_boundary"; | ||
| export * from "./editable_text_view"; | ||
| export * from "./messsage_box"; | ||
| export * from "./message_box"; | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File renamed below |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,7 +165,7 @@ export function stringToDataURL(mimeType: string, content: string) { | |
| return "data:" + mimeType + ";base64," + b64EncodeUnicode(content); | ||
| } | ||
|
|
||
| function checkConvertion( | ||
| function checkConversion( | ||
| type: DataType, | ||
| dataSample: (string | boolean | Date | number)[] | ||
| ) { | ||
|
|
@@ -303,7 +303,7 @@ export function getConvertableTypes( | |
| return true; | ||
| } | ||
| if (dataSample) { | ||
| return checkConvertion( | ||
| return checkConversion( | ||
| t, | ||
| dataSample.map((d) => d && d.toString()) | ||
| ); | ||
|
|
@@ -356,11 +356,11 @@ export function convertColumns( | |
| applyConvertedValues(table, column.name, convertedValues); | ||
| return null; | ||
| } catch (ex) { | ||
| const messgae = `Converting column type from ${originColumn.type} to ${type} failed`; | ||
| console.warn(messgae); | ||
| const message = `Converting column type from ${originColumn.type} to ${type} failed`; | ||
| console.warn(message); | ||
| // rollback type | ||
| column.type = typeBeforeChange; | ||
| return messgae; | ||
| return message; | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -381,7 +381,7 @@ export function isInIFrame() { | |
| } | ||
| } | ||
|
|
||
| export function getAligntment(anchor: Element) { | ||
| export function getAlignment(anchor: Element) { | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possible this is an api |
||
| let alignX: | ||
| | "start-outer" | ||
| | "inner" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ import { AggregationFunctionDescription } from "../../../core/expression"; | |
| import { | ||
| defaultLabelStyle, | ||
| defaultStyle, | ||
| defultBindButtonSize, | ||
| defaultBindButtonSize, | ||
| FluentDataBindingMenuItem, | ||
| FluentDataBindingMenuLabel, | ||
| } from "../panels/widgets/controls/fluentui_customized_components"; | ||
|
|
@@ -85,7 +85,7 @@ interface Builder { | |
| /** | ||
| * Add default value | ||
| */ | ||
| produceDefaultValue(dafaultValue: IDefaultValue): void; | ||
| produceDefaultValue(defaultValue: IDefaultValue): void; | ||
|
|
||
| getMenuItems(): IContextualMenuItem[]; | ||
|
|
||
|
|
@@ -149,7 +149,7 @@ class MenuItemsCreator { | |
| } | ||
| } | ||
|
|
||
| public setFieds( | ||
| public setFields( | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... |
||
| datasetStore: AppStore, | ||
| table?: string, | ||
| kinds?: Dataset.DataKind[], | ||
|
|
@@ -736,11 +736,11 @@ export class MenuItemBuilder implements Builder { | |
| kinds?: Dataset.DataKind[], | ||
| types?: Dataset.DataType[] | ||
| ): void { | ||
| this.menuItemsCreator.setFieds(datasetStore, table, kinds, types); | ||
| this.menuItemsCreator.setFields(datasetStore, table, kinds, types); | ||
| } | ||
|
|
||
| public produceDefaultValue(dafaultValue: IDefaultValue): void { | ||
| this.menuItemsCreator.produceDefaultValue(dafaultValue); | ||
| public produceDefaultValue(defaultValue: IDefaultValue): void { | ||
| this.menuItemsCreator.produceDefaultValue(defaultValue); | ||
| } | ||
|
|
||
| public buildMenu(): void { | ||
|
|
@@ -845,12 +845,12 @@ export class Director { | |
| ...(defaultStyle as any), | ||
| title: { | ||
| ...defaultStyle.title, | ||
| lineHeight: defultBindButtonSize.height, | ||
| lineHeight: defaultBindButtonSize.height, | ||
| borderWidth: "0px", | ||
| }, | ||
| dropdownOptionText: { | ||
| boxSizing: "unset", | ||
| lineHeight: defultBindButtonSize.height, | ||
| lineHeight: defaultBindButtonSize.height, | ||
| }, | ||
| callout: { | ||
| minWidth: 180, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible this is important...