forked from github/codeql
-
Notifications
You must be signed in to change notification settings - Fork 20
PS: Simplify the AST in Powershell #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atement that defines them.
…e extracted AST these are just variables with special names. We insert synthesized AST elements that represent these special variables.
…refers to the individual elements in the pipeline. Add a synthesized variable access that represents this.
…t at least it compiles.
1791d9d to
0fc5778
Compare
chanel-y
approved these changes
Mar 27, 2025
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the PowerShell AST to be much more like the other languages. It also fixes up all the subsequent analyses like control-flow, dataflow, api graphs and models-as-data. Although there are still some parts of API graphs that need to be modified.
In particular, this means that:
AssignStmtis now finally anExprinstead of aStmt. In the Powershell parser this decision probably came from the fact that the right-hand side of anAssignStmtcan be a pipeline, and a pipeline is produced by a statement (for example, by a call to a command likeFoo).Exprclass representing calls. Previously,Cmds wereStmts and member calls whereExprs.DataFlow::Node::asStmtpredicate 🥳 This was necessary because of the above points, but now that pipelines are produced byExprs this is no longer neededI've got more plans for what kinds of rewrites we can do on the AST, but I think this is good enough to merge for now.
The main tool for producing a better AST is the synthesis framework I added in 7f30050 and subsequent commits extend the
Synthesisclass to perform rewrites.Additionally, I've also fixed a couple of issues in the extractor in the first commit: We now recognize more files as Powershell source files, and we've fixed an off-by-one issue in the locations relation.