Update condition for Mariner and Azure Linux installation for artifacts-helper - #105
Update condition for Mariner and Azure Linux installation for artifacts-helper#105ms-nateb wants to merge 2 commits into
Conversation
|
ms-nateb have you done the install steps manually so that you know that the install itself works? Can you increment the version number so when I merge we can publish a new release? |
There was a problem hiding this comment.
Pull request overview
Updates the artifacts-helper install script to recognize Azure Linux 3.0 as a tdnf-based distro (similar to Mariner) so prerequisites can be installed correctly during feature setup.
Changes:
- Extends OS detection to treat
azurelinuxVERSION_ID=3.0like Mariner for package installation. - Minor formatting/line alignment cleanup at end of script.
Comments suppressed due to low confidence (1)
src/artifacts-helper/install.sh:78
- The OS check is very strict (
ID==azurelinuxandVERSION_ID==3.0). If Azure Linux ships patch/minor versions (e.g.3.0.x/3.1) this will fall through tocheck_packages, which relies ondpkg/apt-getand will fail on tdnf-based distros. Consider keying offID==azurelinuxregardless of version,ID_LIKEcontainingmariner, or simply detectingtdnfavailability to select the package manager.
if [[ "${ID}" == "mariner" || ( "${ID}" == "azurelinux" && "${VERSION_ID}" == "3.0" ) ]]; then
tdnf install -y wget ca-certificates
tdnf clean all
else
check_packages wget ca-certificates
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [[ "${ID}" == "mariner" || ( "${ID}" == "azurelinux" && "${VERSION_ID}" == "3.0" ) ]]; then | ||
| tdnf install -y wget ca-certificates | ||
| tdnf clean all |
There was a problem hiding this comment.
This change adds Azure Linux support, but the feature’s stated OS support (see src/artifacts-helper/README.md “OS Support”) currently only mentions Debian/Ubuntu and Mariner. Please update the OS support documentation to include Azure Linux (and any version constraints) so consumers know it’s supported.
There was a problem hiding this comment.
Copilot could we just approach this differently and discover the right package manager? We could probe for tdnf and it found use that, otherwise use dpkg?
There was a problem hiding this comment.
Copilot could we just approach this differently and discover the right package manager? We could probe for tdnf and it found use that, otherwise use dpkg?
|
I took care of this with #107 |
Add support for installing on Azure Linux 3.0