-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SBOM output format #115
Conversation
379fdc7
to
90e97ab
Compare
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
@coderpatros does the CycloneDx mapper contain enough information? Is there anything I am missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me. Although there are a couple of spots that could include more information.
src/Microsoft.ComponentDetection.Contracts/Mappers/CycloneDx.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Contracts/Mappers/CycloneDx.cs
Outdated
Show resolved
Hide resolved
@JamieMagee I can't remember if I've mentioned this to you before. But we also have a |
src/Microsoft.ComponentDetection.Contracts/Mappers/CycloneDx.cs
Outdated
Show resolved
Hide resolved
2b62709
to
0317305
Compare
0317305
to
4fba698
Compare
Build failures are related to dotnet/runtime#61602 |
@JamieMagee I'm really interested by this PR. Now that you fully switched to .NET 6, rebasing this work on top of main should solve previous build failures related to Json/.NET Core 3.x. What do you think ? |
4fba698
to
96a8a85
Compare
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Closing due to low priority / large conflicts, We have an open issue tracking this effort here: #42 and we will revisit the work when resolving that issue. |
This PR adds support for a new
--ManifestFileFormat
flag which accepts:ComponentDetection
CycloneDx
SPDX
Currently
ComponentDetection
(default) andCycloneDx
are implemented, with plans to implementSPDX
once the proof-of-concept is accepted.