Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: analyzer warnings IDE0019, IDE0021, IDE0037 #326

Merged
merged 6 commits into from
Oct 28, 2022

Conversation

daniel-akili
Copy link
Contributor

@daniel-akili daniel-akili commented Oct 24, 2022

Related to #202

@daniel-akili daniel-akili requested a review from a team as a code owner October 24, 2022 19:45
@daniel-akili daniel-akili requested a review from Omotola October 24, 2022 19:45
@JamieMagee JamieMagee changed the title Users/akili/analyzer warnings2 fix: analyzer warnings IDE0019, IDE0021, IDE0037 Oct 24, 2022
@JamieMagee
Copy link
Member

Approved, but it looks like there are conflicts with @RushabhBhansali's latest changes

* fix: IDE0052, IDE0055

* fix: IDE0057

* added verification for dockerfile and spdx detector, minor bug fixes (#322)

* chore(deps): update dependency fluentassertions to v6.8.0 (#324)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency microsoft.visualstudio.threading.analyzers to v17.3.48 (#323)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* remove linux-container detection stage (#327)

* resolved local merge conflicts

* Add new exclusions to .editorconfig (#328)

Add the IDE0053, IDE0200, CA1311, CA1852, and CA1854 exlcusions to .editorconfig to avoid build breaks.

* Add IDE0052 to warning exclusion (#329)

Add IDE0052 to warning exclusion

* resolved PR build failures

Co-authored-by: Daniel Akili <[email protected]>
Co-authored-by: Rushabh <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Coby Allred <[email protected]>
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@RushabhBhansali RushabhBhansali merged commit 2e911a5 into main Oct 28, 2022
@RushabhBhansali RushabhBhansali deleted the users/akili/analyzer-warnings2 branch October 28, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants