Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: analyzer warnings SA1210, SA1414, VSTHRD002, CA1849, VSTHRD103, VSTHRD104 #341

Merged
merged 9 commits into from
Nov 2, 2022
Merged

fix: analyzer warnings SA1210, SA1414, VSTHRD002, CA1849, VSTHRD103, VSTHRD104 #341

merged 9 commits into from
Nov 2, 2022

Conversation

RushabhBhansali
Copy link
Contributor

@RushabhBhansali RushabhBhansali commented Oct 29, 2022 •
edited
Loading

Related to #202

  • fix SA1210: Using directives should be ordered alphabetically

  • fix SA1414: Tuple types in signatures should have element names

  • fix VSTHRD002: synchronously waiting on Task

  • fix CA1849: Call async methods when in an async method

  • fix VSTHRD103: Call async methods when in an async method

@JamieMagee JamieMagee changed the title Users/rbhansali/fix analyzer 10 28 fix: analyzer warnings SA1210, SA1414, VSTHRD002, CA1849, VSTHRD103, VSTHRD104 Oct 31, 2022
JamieMagee
JamieMagee requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments on the async fixes

@RushabhBhansali RushabhBhansali force-pushed the users/rbhansali/fix-analyzer-10-28 branch from a897eda to 9978071 Compare November 2, 2022 03:04
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@RushabhBhansali RushabhBhansali force-pushed the users/rbhansali/fix-analyzer-10-28 branch from 15113d3 to 84a921e Compare November 2, 2022 04:01
@RushabhBhansali RushabhBhansali marked this pull request as ready for review November 2, 2022 15:39
@RushabhBhansali RushabhBhansali requested a review from a team as a code owner November 2, 2022 15:39
@RushabhBhansali RushabhBhansali force-pushed the users/rbhansali/fix-analyzer-10-28 branch from 0da1adc to 2b446d2 Compare November 2, 2022 18:16
@RushabhBhansali RushabhBhansali force-pushed the users/rbhansali/fix-analyzer-10-28 branch from 2b446d2 to fe9e198 Compare November 2, 2022 18:43
@RushabhBhansali RushabhBhansali enabled auto-merge (squash) November 2, 2022 18:43
@RushabhBhansali RushabhBhansali merged commit 2a128f6 into main Nov 2, 2022
@RushabhBhansali RushabhBhansali deleted the users/rbhansali/fix-analyzer-10-28 branch November 2, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RushabhBhansali @JamieMagee