refactor: use Newtonsoft.Json streaming methods
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melotic
approved these changes
Jun 6, 2023
|
LGTM! Although I don't think this affects the manfiest, might be good to just double check that the format is still the same. |
JamieMagee
changed the title
Newtonsoft.Json streaming methodsNewtonsoft.Json streaming methods
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're unable to move to
System.Text.Jsonwith the feature set that is available in .NET 6 (See #231 for more information), this PR optimizes our use ofNewtonsoft.Jsonby using streaming methods for our most allocation-heavy methods where possible.In tests against real world repositories this dropped memory usage by up to 37% when writing the manifest JSON.
There is also some refactoring and tech debt cleanup in tests and documentation.