Skip to content

[testing] Enhancement: UDP barriers for more consistent testing #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[testing] Enhancement: UDP barriers for more consistent testing #1536

wants to merge 2 commits into from

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Apr 28, 2025

This PR adds a few more barrier points to the UDP tests. These are less necessary for the UDP tests as there is no connection set up and tear down but I added these just for symmetry with the TCP tests.

@iyzhang iyzhang requested a review from anandbonde April 28, 2025 18:08
@github-actions GitHub Actions
Copy link

libos = catnap
commit id = fd781b5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 6434497 4297 1823 2926556085 99 2926556085 99
ioc::network::libos::push 17610 521 216 7830837 0 7830837 0
ioc::network::libos::pop 15150 489 202 5641238 0 5641238 0
ioc::network::libos::connect 50 184726 78864 3636498 0 3636498 0
ioc::network::libos::accept 26 130269 54016 1602403 0 1602403 0
demikernel::sgaalloc 11287 127 54 1113720 0 1113720 0
demikernel::sgafree 11543 64 26 685308 0 685308 0
ioc::network::libos::close 18 25552 10611 359905 0 359905 0
ioc::network::libos::pushto 768 379 151 242392 0 242392 0

@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = fd781b5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 26732997 726 292 17138686790 46 17128660186 86
bgc::inetstack::poll 13366499 1667 670 19945822152 54 2807135362 14
ioc::network::libos::push 16281 2801 1152 50157078 0 50157078 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 6023 2667 1047 10196546 0 10193431 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11791 433 173 5366388 0 5366388 0
ioc::network::libos::pop 9299 429 174 3657576 0 3657576 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11804 833 344 3559451 0 3559451 0
bgc::inetstack::tcp::established::background 11804 2018 812 13249136 0 3391604 0
ioc::network::libos::pushto 384 5328 2040 1740863 0 1740863 0
ioc::network::libos::connect 42 39825 16142 1705303 0 1705303 0
bgc::inetstack::tcp::passiveopen::background 42 29457 11842 1007468 0 1007468 0
demikernel::sgaalloc 6503 135 55 971278 0 971278 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11748 955 368 931692 0 931692 0
demikernel::sgafree 8759 82 33 644343 0 644343 0
ioc::network::libos::close 47 2792 1125 63175 0 63175 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 243 266 104 61271 0 61271 0
ioc::network::libos::accept 38 2426 986 55734 0 55734 0
bgc::inetstack::arp::background 10 3123 1252 25464 0 25464 0
bgc::inetstack::icmp::background 1 1861 745 2011 0 2011 0

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = fd781b5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 28337667 200 80 5507125668 19 5507125668 43
bgc::inetstack::poll;inetstack::layer4::poll_once 28337667 378 152 10189008020 36 4676748244 36
bgc::inetstack::poll 14168833 943 378 12813484466 45 2624476446 20
ioc::network::libos::push 16185 1083 440 17580985 0 15447440 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2480 3787 1488 5221127 0 5205910 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11080 320 128 4526096 0 4525174 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11091 441 182 2905236 0 2882456 0
ioc::network::libos::pop 9041 381 153 2758212 0 2758212 0
bgc::inetstack::tcp::established::background 11091 1189 479 10836123 0 2741705 0
ioc::network::libos::push;catnip::runtime::transmit 8777 299 121 2316421 0 2316421 0
ioc::network::libos::connect 42 33462 13456 1367478 0 1307422 0
demikernel::sgaalloc 6503 134 54 713051 0 713051 0
demikernel::sgafree 8759 84 34 660515 0 660515 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11038 307 119 663086 0 652223 0
bgc::inetstack::tcp::passiveopen::background 42 25006 10193 562361 0 507394 0
ioc::network::libos::pushto 384 2248 968 577395 0 446221 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 43 1641 695 141746 0 141746 0
ioc::network::libos::pushto;catnip::runtime::transmit 384 706 303 131173 0 131173 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6370 2543 60056 0 60056 0
ioc::network::libos::close 49 2625 1061 57861 0 57861 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 15230 6247 54967 0 54967 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 214 291 122 51764 0 51764 0
ioc::network::libos::accept 37 2350 962 47922 0 47922 0
bgc::inetstack::arp::background 7 3312 1327 22603 0 22603 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 26 807 324 13260 0 13260 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 603 242 10863 0 10863 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 17 587 247 5742 0 5742 0
bgc::inetstack::icmp::background 1 1609 645 1771 0 1771 0

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = fd781b5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 28396495 201 81 5505008663 19 5505008663 43
bgc::inetstack::poll;inetstack::layer4::poll_once 28396495 375 152 10151820766 36 4641770155 36
bgc::inetstack::poll 14198248 936 379 12803760372 45 2651939606 21
ioc::network::libos::push 16185 1090 450 17679809 0 15432070 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2548 3450 1359 5127405 0 5111336 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11081 325 133 4499667 0 4498455 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11092 435 180 2884315 0 2860615 0
ioc::network::libos::pop 9042 374 152 2754423 0 2754423 0
bgc::inetstack::tcp::established::background 11092 1191 484 10775910 0 2721813 0
ioc::network::libos::push;catnip::runtime::transmit 8777 316 130 2440402 0 2440402 0
ioc::network::libos::connect 42 32314 13502 1327911 0 1271730 0
demikernel::sgaalloc 6503 126 51 722118 0 722118 0
demikernel::sgafree 8759 83 34 670519 0 670519 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11038 325 125 670115 0 659191 0
bgc::inetstack::tcp::passiveopen::background 42 26054 10590 635487 0 582165 0
ioc::network::libos::pushto 384 2206 930 583827 0 439544 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 43 1475 654 147470 0 147470 0
ioc::network::libos::pushto;catnip::runtime::transmit 384 778 326 144283 0 144283 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 248 346 146 63844 0 63844 0
ioc::network::libos::close 49 2648 1070 58516 0 58516 0
ioc::network::libos::connect;catnip::runtime::transmit 42 5962 2356 56181 0 56181 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 13770 5508 53322 0 53322 0
ioc::network::libos::accept 37 2506 1028 49117 0 49117 0
bgc::inetstack::arp::background 7 3847 1562 23916 0 23916 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 26 741 298 13509 0 13509 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 586 237 10924 0 10924 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 17 645 315 6785 0 6785 0
bgc::inetstack::icmp::background 1 1766 715 1917 0 1917 0

@iyzhang iyzhang force-pushed the enhancement-testing-udp-sync-points branch from fd781b5 to b5823d1 Compare May 1, 2025 17:31
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

libos = catnap
commit id = b5823d1

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 6388476 3888 1618 2895614966 99 2895614966 99
ioc::network::libos::push 17610 532 241 7716251 0 7716251 0
ioc::network::libos::pop 14893 465 204 5345396 0 5345396 0
ioc::network::libos::connect 50 176790 70334 3462262 0 3462262 0
ioc::network::libos::accept 26 120631 54430 1424158 0 1424158 0
demikernel::sgaalloc 11287 119 48 1137159 0 1137159 0
demikernel::sgafree 11543 63 27 767987 0 767987 0
ioc::network::libos::close 18 22606 9653 331567 0 331567 0
ioc::network::libos::pushto 768 368 141 243115 0 243115 0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

libos = catpowder
commit id = b5823d1

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 19853868 691 275 12551918608 46 12545495918 85
bgc::inetstack::poll 9926934 1594 635 14640438583 54 2088519975 14
ioc::network::libos::push 16255 3076 1250 50649217 0 50649217 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5330 2750 1066 6531549 0 6528408 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11113 433 172 5419006 0 5419006 0
ioc::network::libos::pop 9058 495 200 3579235 0 3579235 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11113 789 333 3481119 0 3481119 0
bgc::inetstack::tcp::established::background 11113 2044 824 12905732 0 3113420 0
ioc::network::libos::pushto 384 5232 2149 1815955 0 1815955 0
ioc::network::libos::connect 42 41292 16536 1780358 0 1780358 0
bgc::inetstack::tcp::passiveopen::background 42 29768 11867 1007841 0 1007841 0
demikernel::sgaalloc 6503 175 71 907506 0 907506 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11057 1045 400 892188 0 892188 0
demikernel::sgafree 8759 87 35 637831 0 637831 0
ioc::network::libos::close 46 3045 1213 72273 0 72273 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 273 253 99 61772 0 61772 0
ioc::network::libos::accept 38 2399 968 55985 0 55985 0
bgc::inetstack::arp::background 8 3145 1254 19534 0 19534 0
bgc::inetstack::icmp::background 1 1701 676 1838 0 1838 0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

libos = catnip
commit id = b5823d1

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 28762107 201 80 5550890565 19 5550890565 43
bgc::inetstack::poll;inetstack::layer4::poll_once 28762107 374 149 10289969155 36 4734126575 37
bgc::inetstack::poll 14381054 938 373 12894949274 45 2604980119 20
ioc::network::libos::push 16185 1121 454 17657245 0 15514340 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2525 3720 1455 5035947 0 5019964 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11093 315 125 4438717 0 4437588 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11093 431 168 2857410 0 2833546 0
ioc::network::libos::pop 9041 399 158 2792409 0 2792409 0
bgc::inetstack::tcp::established::background 11093 1185 466 10675841 0 2718990 0
ioc::network::libos::push;catnip::runtime::transmit 8777 332 134 2326582 0 2326582 0
ioc::network::libos::connect 42 31672 12788 1341490 0 1287684 0
demikernel::sgaalloc 6503 131 53 703726 0 703726 0
demikernel::sgafree 8759 84 33 663396 0 663396 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11039 312 120 660724 0 650111 0
bgc::inetstack::tcp::passiveopen::background 42 28119 11270 658312 0 601718 0
ioc::network::libos::pushto 384 2145 844 584463 0 446447 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 43 2587 1061 148486 0 148486 0
ioc::network::libos::pushto;catnip::runtime::transmit 384 784 305 138015 0 138015 0
ioc::network::libos::close 49 2617 1050 58378 0 58378 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 232 276 109 57464 0 57464 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 17442 7032 56594 0 56594 0
ioc::network::libos::connect;catnip::runtime::transmit 42 5366 2149 53806 0 53806 0
ioc::network::libos::accept 37 2327 934 48843 0 48843 0
bgc::inetstack::arp::background 7 4071 1610 25030 0 25030 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 26 790 316 13761 0 13761 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 605 242 10613 0 10613 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 17 542 226 6320 0 6320 0
bgc::inetstack::icmp::background 1 1906 756 2065 0 2065 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde Awaiting requested review from anandbonde

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iyzhang