Add generated and raw unsafe Classic COM support - #132
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ef7fa55-eb2a-4360-bd17-05feae50fadb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ef7fa55-eb2a-4360-bd17-05feae50fadb
Mixed-language test coverageWorkflow status: ✅ Passed
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ef7fa55-eb2a-4360-bd17-05feae50fadb
Contributor
Author
|
Addressed the requested changes in
Added unit, real-WinMD, TypeScript, JS runtime, transaction failure-injection, and live E2E regressions. Classic COM E2E passes 17/17; final code review found no remaining high-confidence issues. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ef7fa55-eb2a-4360-bd17-05feae50fadb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ef7fa55-eb2a-4360-bd17-05feae50fadb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ef7fa55-eb2a-4360-bd17-05feae50fadb
shisan (qiutongMS)
approved these changes
Sep 3, 2026
Stop passing the deleted local Buffer shim to the generated consumer compiler now that @types/node supplies Buffer. Include both compiler output streams in future assertion failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
shisan (qiutongMS)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IUnknowninterfaces in JavaScript using static thunks or libffi closuresQueryInterface, canonicalIUnknown,AddRef/Release, owner-thread callbacks, transactional outputs, and reentrant release*Unsafecompanions with explicit pointer, ownership, cleanup, counted-buffer, handle, and interface-replacement strategiesCompatibility and scope
/com,/com/unsafe, and/com/unsafe/rawCapability baseline
For
Microsoft.Windows.SDK.Win32Metadata 71.0.14-preview:Validation
dynwinrt-codegen,dynwinrt, andjswinrt_rsRust test suitesjswinrt_rscompile checkThe full npm suite's known WinUI
nextTicktiming assertion was flaky under load and passed on its isolated rerun.