-
Notifications
You must be signed in to change notification settings - Fork 174
Break out bicep modules for hubs extensibility #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@RolandKrummenacher Sorry for the delay. I fixed this. |
Works now. Thanks. |
- Add @maxlength(22) to clusterName parameter in Analytics app.bicep - Implement automatic truncation in deployment script - Ensure hub names up to 18 chars work (18 + 4 for '-adx' = 22 max) - Prevent deployment failures for longer hub names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β LGTM - Tested and validated
Deployments tested successfully:
- β Public networking (eastus2)
- β Private networking (eastus2)
- β Long hub names with ADX truncation
- β Multiple subscriptions
Changes validated:
- β Modular bicep organization works
- β ADX cluster name validation fixed (@maxlength(22))
- β Private endpoints correctly configured
- β Resource creation and networking successful
Note for future optimization:
Multiple StopTriggers deployment scripts (one per module) run sequentially with private endpoints, adding ~1 min overhead per script. Consider consolidating into a single script in a future PR for efficiency.
Commits added:
- b4b1b13: Fix ADX cluster name length validation
@microsoft-github-policy-service agree [company="Xerilium"] |
@microsoft-github-policy-service agree company="Xerilium" |
π οΈ Description
This PR reorganizes FinOps hubs bicep into a cleaner, more extensible structure while fixing build issues and improving maintainability.
fx
folderX.Y/Z
folders for each publisher/app:#disable-next-line BCP318
with explanations for null safetyπ Checklist
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?