-
Notifications
You must be signed in to change notification settings - Fork 173
Fix broken finops-hub-copilot.zip download link in AI configuration docs #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Co-authored-by: flanakin <[email protected]>
Compress-Archive -Path "$srcPath/*" -DestinationPath $zip | ||
|
||
# Create unversioned copy for specific templates that need stable download links | ||
if ($templateName -eq "finops-hub-copilot") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use one-off logic here. We should be consistent. Also this will break a test so that would also need to be updated.
@@copilot: you have some new feedback! Please review and resolve all comments and I'll let reviewers know by removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes broken download links for GitHub Copilot instructions in the FinOps hubs AI configuration documentation. The issue occurred because documentation links used unversioned filenames (finops-hub-copilot.zip
) while recent releases only included versioned filenames (finops-hub-copilot-v12.zip
), causing 404 errors.
- Modified the packaging script to create both versioned and unversioned ZIP files for the finops-hub-copilot template
- Updated the changelog to document this fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/scripts/Package-Toolkit.ps1 | Added logic to create unversioned copy of finops-hub-copilot.zip alongside the versioned file |
docs-mslearn/toolkit/changelog.md | Added changelog entry documenting the fix for GitHub Copilot instructions download link |
The AI configuration documentation for FinOps hubs contained broken download links that prevented users from accessing the GitHub Copilot instructions. The issue occurred because:
finops-hub-copilot.zip
(unversioned filename)finops-hub-copilot-v12.zip
(versioned filename)/releases/latest/download/
redirect failed due to filename mismatchThis resulted in 404 errors when users tried to download the AI instructions from the Configure AI documentation.
Solution
Modified the packaging script (
Package-Toolkit.ps1
) to create both versioned and unversioned ZIP files specifically for thefinops-hub-copilot
template:finops-hub-copilot-v12.0.zip
(versioned, maintains consistency with other templates)finops-hub-copilot.zip
(unversioned, enables stable documentation links)The fix is minimal and surgical - only the
finops-hub-copilot
template receives this special handling. Other templates continue to use versioned filenames only, maintaining the existing release structure.Testing
Fixes #1803.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.