[AOE] Fixes Reservations-related workbooks link to ISF ratio CSV #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2025 16:19
…k around Log Analytics externaldata limitation
helderpinto
added
Micro PR 🔬
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
There was a problem hiding this comment.
Pull Request Overview
This PR fixes reservations-related workbooks by replacing the Instance Size Flexibility ratios CSV vanity URL with the actual URL to work around a Log Analytics externaldata operator limitation.
Key Changes
- Replaced the vanity URL
https://aka.ms/isfwith the actual URLhttps://ccmstorageprod.blob.core.windows.net/instancesizeflexibility-data/isfratioblob.csvacross all affected KQL queries - Updated the changelog to document the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/optimization-engine/views/workbooks/reservations-usage.json | Updated 9 KQL queries to use the actual ISF CSV URL instead of the vanity URL |
| src/optimization-engine/views/workbooks/reservations-potential.json | Updated 4 KQL queries to use the actual ISF CSV URL instead of the vanity URL |
| src/optimization-engine/views/workbooks/benefits-simulation.json | Updated 7 KQL queries to use the actual ISF CSV URL instead of the vanity URL |
| docs-mslearn/toolkit/changelog.md | Added changelog entry documenting the fix for the ISF ratios CSV URL issue |
flanakin
approved these changes
Sep 29, 2025
| - **Added** | ||
| - Document [how to remove private networking](hubs/private-networking.md#removing-private-networking) and switch back to public access to reduce costs ([#1342](https://github.com/microsoft/finops-toolkit/issues/1342)). | ||
|
|
||
| ### [Optimization engine](optimization-engine/overview.md) |
There was a problem hiding this comment.
We should move this to the section for the next release
There was a problem hiding this comment.
Do you mean this should be moved to the V13 release section? I thought the "unreleased" section was exactly for features to be added to the next release...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Reservations-related workbooks fixed by replacing Instance Size Flexibility ratios CSV vanity URL with actual one to work around Log Analytics
externaldataoperator limitation (recent Log Analytics change).Fixes #1810
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?