Skip to content

Conversation

mpritchard2
Copy link
Contributor

🛠️ Description

MS Learn documentation for using multiple workspaces for performance logs references a new automation variable, but it does not list it. Screenshot included in doc has the variable cut off. This PR updates documentation to include the variable name.

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Copy link
Contributor

@MSBrett MSBrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Variable name verified in codebase at src/optimization-engine/runbooks/recommendations/Recommend-AdvisorCostAugmentedToBlobStorage.ps1:184. Documentation improvement resolves the missing variable name issue.

@MSBrett MSBrett merged commit 5e97a9f into microsoft:dev Oct 1, 2025
1 check passed

@all-contributors please add @mpritchard2 for doc

Copy link
Contributor

@microsoft-github-policy-service[bot]

I've put up a pull request to add @mpritchard2! 🎉

@mpritchard2 mpritchard2 deleted the mpritchard2/update-aoe-docs branch October 1, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review 👀 PR that is ready to be reviewed Tool: Optimization Engine Azure Optimization Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants