Skip to content

Button: Making all MenuButton props optional #8975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2019
Merged

Button: Making all MenuButton props optional #8975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54aaaed
Button: Making all MenuButton props optional.
khmakoto May 6, 2019
8843056
Adding change file.
khmakoto May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/experiments/buttonOptionalMenu_2019-05-06-18-13.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/experiments",
"comment": "Button: Making all MenuButton props optional.",
"type": "minor"
}
],
"packageName": "@uifabric/experiments",
"email": "[email protected]"
}
6 changes: 3 additions & 3 deletions packages/experiments/src/components/Button/MenuButton/MenuButton.types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface IMenuButtonSlots extends IButtonSlots {
/**
* Defines the contextual menu that appears when you click on the MenuButton.
*/
menu: IContextualMenuSlot;
menu?: IContextualMenuSlot;

/**
* Defines the menu chevron icon that is displayed insisde the MenuButton.
Expand Down Expand Up @@ -65,12 +65,12 @@ export interface IMenuButtonViewProps extends Pick<IButtonViewProps, 'buttonRef'
/**
* Defines a callback that runs after the MenuButton's contextual menu has been closed (removed from the DOM).
*/
onMenuDismiss: () => void;
onMenuDismiss?: () => void;

/**
* Defines the target that the contextual menu uses to position itself.
*/
menuTarget: HTMLElement | undefined;
menuTarget?: HTMLElement | undefined;
}

export interface IMenuButtonTokens extends IButtonTokens {}
Expand Down