-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket web #1005
Websocket web #1005
Conversation
LGTM 🚀 The changes look good! The Some points that I appreciate:
If there were any functional issues or concerns that arise as these changes are rolled out, they would likely be evident through automated tests or real-world use-cases. At this point, the changes appear to improve upon existing functionality while adhering to good software engineering practices.
|
Migrate web socket client into node/web agnostic file
Here's a high-level summary of the changes in GIT_DIFF:
Introduce
RunClient
as a core component for starting and managing script execution. 🐍Move script logic to
RunClient
, encapsulating complex interactions with the backend. 🚀Replace direct interaction with the backend API throughout the application with calls to the new
RunClient
. 🔄The new
RunClient
supports asynchronous operations, making it a single point of control for executing and managing scripts. ⏳Implement result handling and event listeners in the
RunClient
, abstracting the complexities of data flow away from other components. 🔍Expose public APIs like
startScript
andabortScript
through theRunClient
interface, making scripting operations easier to use for other parts of the application. 🌐These changes improve code organization, simplify interactions with the backend, and make script execution more manageable across different parts of the application. 🛠️