Implement ORAS helper command #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
reviewed
Apr 5, 2024
cmd/azoras/README.md
Outdated
Comment on lines
20
to
21
| azoras doesn't handle authentication, you need to login to your Azure ACR registry with the ORAS CLI. | ||
| See https://oras.land/docs/how_to_guides/authentication for more information. |
There was a problem hiding this comment.
azoras doesn't handle authentication seems to conflict with azoras provides a helper subcommand to login. I think I get what this is trying to say (it won't use any ambient auth if you go directly to run the azoras deprecate command) but that doesn't seem all that important vs. listing the relatively painless commands that you actually need to run to get it set up.
I think this could be moved into a note after the instructions, and I don't think it needs to be worded like azoras is lacking a major feature, just pointing out what's going on behind the scenes.
There was a problem hiding this comment.
Good point, I'll rephrase this section.
Co-authored-by: Davis Goodin <[email protected]>
|
Moved to our internal repo for now while we work on a pipeline etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azorasis a tool that helps work with the ORAS CLI and Azure ACR.The subcommands implement common workflows for image annotations and maintenance.
It currently implement three basic workflows:
azoras install: Install the ORAS CLI from GitHub releasesazoras login: Logs in the ORAS CLI to Azure ACR using the Azure CLIazoras deprecate: Adds a end-of-life annotation to the given image or list of images