Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion error.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package mssql
import (
"database/sql/driver"
"fmt"
"strings"
)

// Error represents an SQL Server error. This
Expand All @@ -24,7 +25,18 @@ type Error struct {
}

func (e Error) Error() string {
return "mssql: " + e.Message
errChain := e.All
if len(errChain) == 0 {
errChain = []Error{e}
}
var msg strings.Builder
Comment thread
dlevy-msft-sql marked this conversation as resolved.
for i, err := range errChain {
if i > 0 {
msg.WriteByte('\n')
}
fmt.Fprintf(&msg, "mssql: %s (%d)", err.Message, err.Number)
}
return msg.String()
}
Comment thread
jegorbunov marked this conversation as resolved.

func (e Error) String() string {
Expand Down
26 changes: 26 additions & 0 deletions queries_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,19 @@ func TestError(t *testing.T) {
if sqlerr.Number != 2812 { // Could not find stored procedure 'bad'
t.Fatalf("Should be specific error code 2812, actually %d %s", sqlerr.Number, sqlerr)
}
if len(sqlerr.All) != 1 {
t.Fatalf("Should have one error, actually %d: %+v", len(sqlerr.All), sqlerr.All)
}
if sqlerr.Number != sqlerr.All[0].Number {
t.Fatalf("Should have the same error number, actually %d and %d", sqlerr.Number, sqlerr.All[0].Number)
}

// Error() reports one and only error in the list, in this case:
// "mssql: Could not find stored procedure 'bad'. (2812)"
expectedErrorText := fmt.Sprintf("mssql: %s (%d)", sqlerr.Message, sqlerr.Number)
if err.Error() != expectedErrorText {
t.Fatalf("Expected error text '%s', got '%s'", expectedErrorText, err.Error())
}
}
}

Expand Down Expand Up @@ -768,6 +781,19 @@ func TestMultipleErrors(t *testing.T) {
if sqlerr.All[0].Number != 8111 { // Cannot define PRIMARY KEY constraint on nullable column in table
t.Fatalf("Should be specific error code 8111, actually %d %s", sqlerr.All[0].Number, sqlerr.All[0])
}

// Error() reports all error messages in the same order as
// they are reported by tools like sqlcmd (first to last):
// mssql: Cannot define PRIMARY KEY constraint on nullable column in table '#bad'. (8111)
// mssql: Could not create constraint or index. See previous errors. (1750)
expectedErrorText := fmt.Sprintf(
"mssql: %s (%d)\nmssql: %s (%d)",
sqlerr.All[0].Message, sqlerr.All[0].Number,
sqlerr.All[1].Message, sqlerr.All[1].Number,
)
if err.Error() != expectedErrorText {
t.Fatalf("Expected error text '%s', got '%s'", expectedErrorText, err.Error())
}
}
}

Expand Down
Loading