Skip to content

fix: propagate context deadline to readPrelogin to prevent hangs #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlevy-msft-sql wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: propagate context deadline to readPrelogin to prevent hangs #360

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0d5021f
fix: propagate context deadline to readPrelogin to prevent hangs
dlevy-msft-sql Apr 24, 2026
205da72
fix: align TestLoginTimeout error handling with TestQueryTimeout
dlevy-msft-sql Apr 25, 2026
d5a8863
fix: close connection on prelogin error, extract timeout helper, impr…
dlevy-msft-sql Apr 26, 2026
1e6a016
fix: check ctx.Err() before deadline in preloginTimeout
dlevy-msft-sql Apr 26, 2026
1f33bbf
fix: close connection on context cancel during prelogin read
dlevy-msft-sql Apr 26, 2026
02fc140
fix: use deferred close to prevent socket leaks on all connect error …
dlevy-msft-sql Apr 26, 2026
0caca81
fix: prevent data race on timeout restore and double close on reroute
dlevy-msft-sql Apr 26, 2026
997d219
test: assert error types in prelogin integration tests
dlevy-msft-sql Apr 26, 2026
ef5cff6
fix: wait for cancel-watcher goroutine before restoring timeout
dlevy-msft-sql Apr 26, 2026
c2f757b
fix: clarify cancel watcher comment to match unconditional behavior
dlevy-msft-sql Apr 26, 2026
e128bf0
fix: defer cancel and stop timer in context cancel test
dlevy-msft-sql Apr 26, 2026
0967bd8
fix: wrap db.Conn in goroutine with hard timeout in integration tests
dlevy-msft-sql Apr 26, 2026
f635122
fix: handle socket timeout racing with context deadline in prelogin
dlevy-msft-sql Apr 26, 2026
f82172f
fix: remove overly broad strings.Contains timeout fallback in test
dlevy-msft-sql Apr 26, 2026
dd27d3d
test: add coverage for socket timeout, expired context, and routing r…
dlevy-msft-sql Apr 27, 2026
7b213d2
style: align whitespace in routing test
dlevy-msft-sql Apr 27, 2026
9955d5a
fix: improve prelogin timeout error handling and test assertions
dlevy-msft-sql Apr 27, 2026
b8cf900
fix: use t.Errorf in goroutines and handle Accept errors in routing test
dlevy-msft-sql Apr 27, 2026
3b19ff3
fix: add tokenLoginAck to routing mock and use PingContext with timeout
dlevy-msft-sql Apr 27, 2026
5e5c647
test: improve patch coverage for prelogin context deadline
dlevy-msft-sql Apr 27, 2026
5358a71
fix: avoid t.Fatal from goroutine in TestConnectSuccessfulPreloginAnd…
dlevy-msft-sql Apr 27, 2026
4d3b4ac
fix: correct comment order in pastDeadlineContext documentation
dlevy-msft-sql Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading