Skip to content

Commit

Permalink
samples: remove nginxhttps sample
Browse files Browse the repository at this point in the history
This sample was meant to show support for pulling images with v1 manifest schema versions.

The nginxhttps image has been modified in https://hub.docker.com/r/ymqytw/nginxhttps/tags such that we are no longer able to pull it:

$ docker pull ymqytw/nginxhttps:1.5
Error response from daemon: missing signature key

We may remove this sample since schema version 1 manifests are deprecated per
https://docs.docker.com/engine/deprecated/#pushing-and-pulling-with-image-manifest-v2-schema-1 :
"These legacy formats should no longer be used, and users are recommended to update images to use current formats, or to upgrade to more current
images". This schema version was used by old docker versions. Further OCI spec
https://github.com/opencontainers/image-spec/blob/main/manifest.md#image-manifest-property-descriptions only supports schema version 2.

Signed-off-by: Saul Paredes <[email protected]>
  • Loading branch information
Redent0r committed Nov 8, 2024
1 parent 396e0d2 commit 93993f2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.

This file was deleted.

1 change: 0 additions & 1 deletion src/tools/genpolicy/policy_samples.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
"kubernetes/fixtures/quota.yaml"
],
"needs_containerd_pull": [
"kubernetes/fixtures/rc-nginxhttps.yaml",
"pod/pod-many-layers.yaml"
],
"common_images": [
Expand Down

0 comments on commit 93993f2

Please sign in to comment.