runtime: disable protection check #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enableProtection() is called when confidential_guest=true, so we disable this check to allow us to test running with confidential_guest=true and sev_snp_guest=false. Note this was already done by Wedson previously to allow testing on non-SNP CPUs, but the purpose here is different. Signed-off-by: Aurelien Bombo <[email protected]>
sprt
force-pushed
the
sprt/debug-conf-guest
branch
from
23e3dba to
dcdc39a
Compare
dallasd1
reviewed
Jan 12, 2024
| @@ -474,7 +474,8 @@ func (clh *cloudHypervisor) enableProtection() error { | |||
| return nil | |||
|
|
|||
| default: | |||
| return errors.New("This system doesn't support Confidential Computing (Guest Protection)") | |||
| // Allow running with no hardware protection for testing. | |||
| return nil | |||
There was a problem hiding this comment.
[nit] would it be useful to add a log here saying there's no hardware protection?
|
Is there a pointer to the new debug file with these options? |
Yep I linked the spec PR in the description 🙂 |
danmihai1
approved these changes
Jan 12, 2024
dallasd1
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Summary
microsoft/azurelinux#6942 introduces a debug config file with confidential_guest=true and sev_snp_guest=false. This PR enables that config file to be used. See commit message for more info.
Test Methodology
Local testing