Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: update pod-cm3.yaml sample #155

Closed
wants to merge 1 commit into from
Closed

Conversation

danmihai1
Copy link

Update sample file after recent genpolicy changes.

Update sample file after recent changes.

Signed-off-by: Dan Mihai <[email protected]>
@danmihai1 danmihai1 requested review from a team as code owners January 26, 2024 18:27
@Redent0r
Copy link

I'm already updating this sample in #152 and was able to get 100% test pass with those changes.

@sprt sprt added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jan 26, 2024
@danmihai1
Copy link
Author

I'm already updating this sample in #152 and was able to get 100% test pass with those changes.

The problem with #152 is that rules.rego should be in the first commit (because it's relevant for upstream porting) and the description of the first commit should be updated to reflect that change. Do you have a good plan to fix those issues?

@sprt
Copy link
Collaborator

sprt commented Jan 30, 2024

Can we close this since #152 got merged?

@danmihai1 danmihai1 closed this Jan 31, 2024
@danmihai1 danmihai1 deleted the danmihai1/pod-cm3 branch January 31, 2024 14:21
@sprt sprt removed the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants