Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: use nix::mount for OverlayFS to overcome mounting limitations #293

Open
wants to merge 1 commit into
base: msft-main
Choose a base branch
from

Conversation

miz060
Copy link
Member

@miz060 miz060 commented Jan 14, 2025

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

In overlay, Replaces mount(8) with nix::mount to address limitations in handling multiple lowerdir entries for OverlayFS, ensuring compatibility with updated mount API behaviors.

Test Methodology
  • Manual validation using AKS cluster
  • TODO

@miz060 miz060 force-pushed the mitchzhu/switch_overlay_mount branch from 3d3fd4c to f444bc2 Compare January 14, 2025 02:38
@miz060 miz060 force-pushed the mitchzhu/switch_overlay_mount branch from f444bc2 to aa4424f Compare January 14, 2025 18:46
@miz060 miz060 marked this pull request as ready for review January 14, 2025 18:47
@miz060 miz060 requested review from a team as code owners January 14, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants